Re: [PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

[Samuel Ortiz <sameo@linux.intel.com>]

On Mon, Apr 08, 2013 at 01:40:40PM -0700, Andrey Smirnov wrote:
> On Mon, Apr 8, 2013 at 1:09 PM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> > On Mon, Apr 08, 2013 at 11:34:43AM -0700, Andrey Smirnov wrote:
> > > On Mon, Apr 8, 2013 at 3:16 AM, Samuel Ortiz <sameo@linux.intel.com>
> > wrote:
> > > > This file doesn't exist yet, which breaks bisectability.
> > > > I'm fine with you including it with the first patch. I will prepare a
> > > branch
> > > > with the mfd patches from your serie for Mauro to pull from.
> > > >
> > >
> > > It was initially one single patch(in v1), and I split it in three upon
> > > Hans' request(for ease of reviewing).
> > It probably made sense then, but now, as I said, it breaks bisectability.
> > So
> > I'd appreciate if you could add this header file to this first patch so
> > that I
> > can merge the MFD parts independently.
> > Again, I will provide a branch for Mauro to pull from and apply the
> > remaining
> > patches on top of it.
> >
> >
> OK, I will squash the commits and make another version of the patches.
The separation of the patches as it is now looks good to me. But you need to
add the media header to the first MFD patches, no need to squash commits
together.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/