* [PATCH] [media] vpif_display: fix error return code in vpif_probe()
@ 2013-05-13 5:57 Wei Yongjun
2013-05-13 6:04 ` Prabhakar Lad
0 siblings, 1 reply; 4+ messages in thread
From: Wei Yongjun @ 2013-05-13 5:57 UTC (permalink / raw)
To: prabhakar.csengg, mchehab
Cc: yongjun_wei, linux-media, davinci-linux-open-source
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return -ENODEV in the subdevice register error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/media/platform/davinci/vpif_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c
index 1b3fb5c..50b2f39 100644
--- a/drivers/media/platform/davinci/vpif_display.c
+++ b/drivers/media/platform/davinci/vpif_display.c
@@ -1813,6 +1813,7 @@ static __init int vpif_probe(struct platform_device *pdev)
NULL);
if (!vpif_obj.sd[i]) {
vpif_err("Error registering v4l2 subdevice\n");
+ err = -ENODEV;
goto probe_subdev_out;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] [media] vpif_display: fix error return code in vpif_probe()
2013-05-13 5:57 [PATCH] [media] vpif_display: fix error return code in vpif_probe() Wei Yongjun
@ 2013-05-13 6:04 ` Prabhakar Lad
2013-05-23 9:25 ` Prabhakar Lad
0 siblings, 1 reply; 4+ messages in thread
From: Prabhakar Lad @ 2013-05-13 6:04 UTC (permalink / raw)
To: Wei Yongjun; +Cc: mchehab, yongjun_wei, linux-media, davinci-linux-open-source
Hi Wei,
Thanks for the patch.
On Mon, May 13, 2013 at 11:27 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -ENODEV in the subdevice register error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [media] vpif_display: fix error return code in vpif_probe()
2013-05-13 6:04 ` Prabhakar Lad
@ 2013-05-23 9:25 ` Prabhakar Lad
2013-05-23 9:26 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Prabhakar Lad @ 2013-05-23 9:25 UTC (permalink / raw)
To: Hans Verkuil
Cc: mchehab, yongjun_wei, linux-media, davinci-linux-open-source,
Wei Yongjun
Hi Hans,
On Mon, May 13, 2013 at 11:34 AM, Prabhakar Lad
<prabhakar.csengg@gmail.com> wrote:
> Hi Wei,
>
> Thanks for the patch.
>
> On Mon, May 13, 2013 at 11:27 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Fix to return -ENODEV in the subdevice register error handling
>> case instead of 0, as done elsewhere in this function.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
Can you pick this patch ? and a similar looking patch for vpif display.
Regards,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [media] vpif_display: fix error return code in vpif_probe()
2013-05-23 9:25 ` Prabhakar Lad
@ 2013-05-23 9:26 ` Hans Verkuil
0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2013-05-23 9:26 UTC (permalink / raw)
To: Prabhakar Lad
Cc: Hans Verkuil, mchehab, yongjun_wei, linux-media,
davinci-linux-open-source, Wei Yongjun
On Thu 23 May 2013 11:25:25 Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, May 13, 2013 at 11:34 AM, Prabhakar Lad
> <prabhakar.csengg@gmail.com> wrote:
> > Hi Wei,
> >
> > Thanks for the patch.
> >
> > On Mon, May 13, 2013 at 11:27 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >>
> >> Fix to return -ENODEV in the subdevice register error handling
> >> case instead of 0, as done elsewhere in this function.
> >>
> >> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> >
> Can you pick this patch ? and a similar looking patch for vpif display.
It's already in my queue.
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-23 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-13 5:57 [PATCH] [media] vpif_display: fix error return code in vpif_probe() Wei Yongjun
2013-05-13 6:04 ` Prabhakar Lad
2013-05-23 9:25 ` Prabhakar Lad
2013-05-23 9:26 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox