From: Dan Carpenter <dan.carpenter@oracle.com>
To: m.chehab@samsung.com
Cc: linux-media@vger.kernel.org
Subject: re: [media] cx23885-dvb: use a better approach to hook set_frontend
Date: Mon, 2 Sep 2013 12:20:07 +0300 [thread overview]
Message-ID: <20130902092006.GB30037@elgon.mountain> (raw)
Hello Mauro Carvalho Chehab,
This is a semi-automatic email about new static checker warnings.
The patch 15472faf1259: "[media] cx23885-dvb: use a better approach
to hook set_frontend" from Aug 9, 2013, leads to the following Smatch
complaint:
drivers/media/pci/cx23885/cx23885-dvb.c:790 dvb_register()
error: we previously assumed 'fe0->dvb.frontend' could be null (see line 784)
drivers/media/pci/cx23885/cx23885-dvb.c
783 &i2c_bus->i2c_adap);
784 if (fe0->dvb.frontend != NULL) {
^^^^^^^^^^^^^^^^^^^^^^^^^
Existing check.
785 dvb_attach(tda18271_attach, fe0->dvb.frontend,
786 0x60, &dev->i2c_bus[1].i2c_adap,
787 &hauppauge_hvr127x_config);
788 }
789 if (dev->board == CX23885_BOARD_HAUPPAUGE_HVR1275)
790 cx23885_set_frontend_hook(port, fe0->dvb.frontend);
^^^^^^^^^^^^^^^^^
Patch adds dereference.
791 break;
792 case CX23885_BOARD_HAUPPAUGE_HVR1255:
regards,
dan carpenter
next reply other threads:[~2013-09-02 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 9:20 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-01 10:25 [media] cx23885-dvb: use a better approach to hook set_frontend Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902092006.GB30037@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox