From: Dan Carpenter <dan.carpenter@oracle.com>
To: m.chehab@samsung.com
Cc: linux-media@vger.kernel.org
Subject: re: [media] cx23885-dvb: use a better approach to hook set_frontend
Date: Fri, 1 Nov 2013 13:25:22 +0300 [thread overview]
Message-ID: <20131101102522.GF29795@longonot.mountain> (raw)
Hello Mauro Carvalho Chehab,
The patch 15472faf1259: "[media] cx23885-dvb: use a better approach
to hook set_frontend" from Aug 9, 2013, leads to the following
warning:
"drivers/media/pci/cx23885/cx23885-dvb.c:795 dvb_register()
error: we previously assumed 'fe0->dvb.frontend' could be null (see line 789)"
drivers/media/pci/cx23885/cx23885-dvb.c
789 if (fe0->dvb.frontend != NULL) {
^^^^^^^^^^^^^^^^^^^^^^^^^
Null check.
790 dvb_attach(tda18271_attach, fe0->dvb.frontend,
791 0x60, &dev->i2c_bus[1].i2c_adap,
792 &hauppauge_hvr127x_config);
793 }
794 if (dev->board == CX23885_BOARD_HAUPPAUGE_HVR1275)
795 cx23885_set_frontend_hook(port, fe0->dvb.frontend);
^^^^^^^^^^^^^^^^^
New unchecked dereference.
796 break;
[snip]
1138 case CX23885_BOARD_MYGICA_X8506:
1139 i2c_bus = &dev->i2c_bus[0];
1140 i2c_bus2 = &dev->i2c_bus[1];
1141 fe0->dvb.frontend = dvb_attach(lgs8gxx_attach,
1142 &mygica_x8506_lgs8gl5_config,
1143 &i2c_bus->i2c_adap);
1144 if (fe0->dvb.frontend != NULL) {
^^^^^^^^^^^^^^^^^^^^^^^^^
check.
1145 dvb_attach(xc5000_attach,
1146 fe0->dvb.frontend,
1147 &i2c_bus2->i2c_adap,
1148 &mygica_x8506_xc5000_config);
1149 }
1150 cx23885_set_frontend_hook(port, fe0->dvb.frontend);
^^^^^^^^^^^^^^^^^
Dereference.
1151 break;
regards,
dan carpenter
next reply other threads:[~2013-11-01 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 10:25 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-02 9:20 [media] cx23885-dvb: use a better approach to hook set_frontend Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101102522.GF29795@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox