From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Antti Palosaari <crope@iki.fi>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org
Subject: [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?
Date: Mon, 5 May 2014 22:02:56 +0300 [thread overview]
Message-ID: <20140505190256.GP4963@mwanda> (raw)
tree: git://linuxtv.org/snawrocki/samsung.git for-v3.16
head: 13b46c7a03adbcc347b77a13ed27066bc92d515c
commit: 192292403147877c7d5f737a3cc751ded397aef7 [45/81] [media] em28xx: add [2013:025f] PCTV tripleStick (292e)
drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?
drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: maybe use && instead of &
drivers/media/tuners/si2157.c:44 si2157_cmd_execute() warn: add some parenthesis here?
drivers/media/tuners/si2157.c:44 si2157_cmd_execute() warn: maybe use && instead of &
git remote add linuxtv-samsung git://linuxtv.org/snawrocki/samsung.git
git remote update linuxtv-samsung
git checkout 192292403147877c7d5f737a3cc751ded397aef7
vim +47 drivers/media/dvb-frontends/si2168.c
845f3505 Antti Palosaari 2014-04-10 31 goto err_mutex_unlock;
845f3505 Antti Palosaari 2014-04-10 32 } else if (ret != cmd->rlen) {
845f3505 Antti Palosaari 2014-04-10 33 ret = -EREMOTEIO;
845f3505 Antti Palosaari 2014-04-10 34 goto err_mutex_unlock;
845f3505 Antti Palosaari 2014-04-10 35 }
845f3505 Antti Palosaari 2014-04-10 36
845f3505 Antti Palosaari 2014-04-10 37 /* firmware ready? */
845f3505 Antti Palosaari 2014-04-10 38 if ((cmd->args[0] >> 7) & 0x01)
845f3505 Antti Palosaari 2014-04-10 39 break;
845f3505 Antti Palosaari 2014-04-10 40 }
845f3505 Antti Palosaari 2014-04-10 41
845f3505 Antti Palosaari 2014-04-10 42 dev_dbg(&s->client->dev, "%s: cmd execution took %d ms\n",
845f3505 Antti Palosaari 2014-04-10 43 __func__,
845f3505 Antti Palosaari 2014-04-10 44 jiffies_to_msecs(jiffies) -
845f3505 Antti Palosaari 2014-04-10 45 (jiffies_to_msecs(timeout) - TIMEOUT));
845f3505 Antti Palosaari 2014-04-10 46
845f3505 Antti Palosaari 2014-04-10 @47 if (!(cmd->args[0] >> 7) & 0x01) {
This should be: if (!((md->args[0] >> 7) & 0x01)) {
Otherwise it is a precedence error where it does the negate before the
bitwise AND.
845f3505 Antti Palosaari 2014-04-10 48 ret = -ETIMEDOUT;
845f3505 Antti Palosaari 2014-04-10 49 goto err_mutex_unlock;
845f3505 Antti Palosaari 2014-04-10 50 }
845f3505 Antti Palosaari 2014-04-10 51 }
845f3505 Antti Palosaari 2014-04-10 52
845f3505 Antti Palosaari 2014-04-10 53 ret = 0;
845f3505 Antti Palosaari 2014-04-10 54
845f3505 Antti Palosaari 2014-04-10 55 err_mutex_unlock:
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
next reply other threads:[~2014-05-05 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 19:02 Dan Carpenter [this message]
2014-05-05 20:52 ` [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here? Antti Palosaari
2014-05-20 12:01 ` Dan Carpenter
2014-05-20 15:10 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505190256.GP4963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=crope@iki.fi \
--cc=kbuild@01.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).