From: Dan Carpenter <dan.carpenter@oracle.com>
To: Antti Palosaari <crope@iki.fi>
Cc: kbuild@01.org, Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org
Subject: Re: [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?
Date: Tue, 20 May 2014 15:01:41 +0300 [thread overview]
Message-ID: <20140520120141.GE17724@mwanda> (raw)
In-Reply-To: <5367FA1E.9030800@iki.fi>
On Mon, May 05, 2014 at 11:52:46PM +0300, Antti Palosaari wrote:
> >845f3505 Antti Palosaari 2014-04-10 46
> >845f3505 Antti Palosaari 2014-04-10 @47 if (!(cmd->args[0] >> 7) & 0x01) {
> >
> >This should be: if (!((md->args[0] >> 7) & 0x01)) {
> >Otherwise it is a precedence error where it does the negate before the
> >bitwise AND.
>
> That was already on my TODO list as daily media build test sparse
> warned it already http://hverkuil.home.xs4all.nl/logs/Monday.log
>
> I am waiting for media/master kernel upgrades from 3.15-rc1 as that
> kernel will hang whole machine when em28xx driver used (em28xx
> driver is USB bridge for those si2168 and si2157).
>
Wait, what? This is a one liner. I haven't understood the connection
with 3.15-rc1?
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-20 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 19:02 [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here? Dan Carpenter
2014-05-05 20:52 ` Antti Palosaari
2014-05-20 12:01 ` Dan Carpenter [this message]
2014-05-20 15:10 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520120141.GE17724@mwanda \
--to=dan.carpenter@oracle.com \
--cc=crope@iki.fi \
--cc=kbuild@01.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox