From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH] [media] fix a warning on avr32 arch
Date: Thu, 30 Oct 2014 14:15:29 +0100 [thread overview]
Message-ID: <20141030141529.23db53f3@kant> (raw)
In-Reply-To: <3948e2c09f98e556afe11f0e3d348bbe610af31e.1414664215.git.mchehab@osg.samsung.com>
On Oct 30 Mauro Carvalho Chehab wrote:
> on avr32 arch, those warnings happen:
> drivers/media/firewire/firedtv-fw.c: In function 'node_update':
> drivers/media/firewire/firedtv-fw.c:329: warning: comparison is always true due to limited range of data type
>
> In this particular case, the signal is desired, as the isochannel
> var can be initalized with -1 inside the driver.
>
> So, change the type to s8, to avoid issues on archs where char
> is unsigned.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Reviewed-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
>
> diff --git a/drivers/media/firewire/firedtv.h b/drivers/media/firewire/firedtv.h
> index c2ba085e0d20..346a85be6de2 100644
> --- a/drivers/media/firewire/firedtv.h
> +++ b/drivers/media/firewire/firedtv.h
> @@ -96,7 +96,7 @@ struct firedtv {
>
> enum model_type type;
> char subunit;
> - char isochannel;
> + s8 isochannel;
> struct fdtv_ir_context *ir_context;
>
> fe_sec_voltage_t voltage;
--
Stefan Richter
-=====-====- =-=- ====-
http://arcgraph.de/sr/
prev parent reply other threads:[~2014-10-30 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 10:16 [PATCH] [media] fix a warning on avr32 arch Mauro Carvalho Chehab
2014-10-30 13:15 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030141529.23db53f3@kant \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=mchehab@infradead.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox