* [PATCH] [media] fix a warning on avr32 arch
@ 2014-10-30 10:16 Mauro Carvalho Chehab
2014-10-30 13:15 ` Stefan Richter
0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2014-10-30 10:16 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Mauro Carvalho Chehab, Mauro Carvalho Chehab, Stefan Richter,
linux1394-devel
on avr32 arch, those warnings happen:
drivers/media/firewire/firedtv-fw.c: In function 'node_update':
drivers/media/firewire/firedtv-fw.c:329: warning: comparison is always true due to limited range of data type
In this particular case, the signal is desired, as the isochannel
var can be initalized with -1 inside the driver.
So, change the type to s8, to avoid issues on archs where char
is unsigned.
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
diff --git a/drivers/media/firewire/firedtv.h b/drivers/media/firewire/firedtv.h
index c2ba085e0d20..346a85be6de2 100644
--- a/drivers/media/firewire/firedtv.h
+++ b/drivers/media/firewire/firedtv.h
@@ -96,7 +96,7 @@ struct firedtv {
enum model_type type;
char subunit;
- char isochannel;
+ s8 isochannel;
struct fdtv_ir_context *ir_context;
fe_sec_voltage_t voltage;
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] [media] fix a warning on avr32 arch
2014-10-30 10:16 [PATCH] [media] fix a warning on avr32 arch Mauro Carvalho Chehab
@ 2014-10-30 13:15 ` Stefan Richter
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Richter @ 2014-10-30 13:15 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab, linux1394-devel
On Oct 30 Mauro Carvalho Chehab wrote:
> on avr32 arch, those warnings happen:
> drivers/media/firewire/firedtv-fw.c: In function 'node_update':
> drivers/media/firewire/firedtv-fw.c:329: warning: comparison is always true due to limited range of data type
>
> In this particular case, the signal is desired, as the isochannel
> var can be initalized with -1 inside the driver.
>
> So, change the type to s8, to avoid issues on archs where char
> is unsigned.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Reviewed-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
>
> diff --git a/drivers/media/firewire/firedtv.h b/drivers/media/firewire/firedtv.h
> index c2ba085e0d20..346a85be6de2 100644
> --- a/drivers/media/firewire/firedtv.h
> +++ b/drivers/media/firewire/firedtv.h
> @@ -96,7 +96,7 @@ struct firedtv {
>
> enum model_type type;
> char subunit;
> - char isochannel;
> + s8 isochannel;
> struct fdtv_ir_context *ir_context;
>
> fe_sec_voltage_t voltage;
--
Stefan Richter
-=====-====- =-=- ====-
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-30 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-30 10:16 [PATCH] [media] fix a warning on avr32 arch Mauro Carvalho Chehab
2014-10-30 13:15 ` Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox