From: Jonathan Corbet <corbet@lwn.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG
Date: Mon, 15 Dec 2014 09:04:04 -0500 [thread overview]
Message-ID: <20141215090404.6d5cb86e@lwn.net> (raw)
In-Reply-To: <1418651737-10016-1-git-send-email-geert@linux-m68k.org>
On Mon, 15 Dec 2014 14:55:37 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m:
>
> drivers/built-in.o: In function `mcam_v4l_open':
> mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops'
> mcam-core.c:(.text+0x1c2eb0): undefined reference to `vb2_dma_sg_init_ctx'
> drivers/built-in.o: In function `mcam_v4l_release':
> mcam-core.c:(.text+0x1c34bf): undefined reference to `vb2_dma_sg_cleanup_ctx'
I've been mildly resistant to this because I've never figured out how
such a configuration can come about. The Cafe chip only appeared in the
OLPC XO-1 and cannot even come close to doing S/G I/O. So this patch
robs a bit of memory for no use on a platform that can ill afford it.
OTOH, the number of people building contemporary kernels for the XO-1 has
got to be pretty small. So, in the interest of mollifying randconfig
users out there, you can add my:
Acked-by: Jonathan Corbet <corbet@lwn.net>
jon
next prev parent reply other threads:[~2014-12-15 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 13:55 [PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG Geert Uytterhoeven
2014-12-15 14:04 ` Jonathan Corbet [this message]
2014-12-15 14:10 ` Geert Uytterhoeven
2014-12-15 14:13 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215090404.6d5cb86e@lwn.net \
--to=corbet@lwn.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox