Linux Media Controller development
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG
Date: Mon, 15 Dec 2014 09:13:56 -0500	[thread overview]
Message-ID: <20141215091356.3f03f0d7@lwn.net> (raw)
In-Reply-To: <CAMuHMdVGXyGJU1SoTMCX4P5BJEStpYrp0_dJ8TqaPhQTC_-guA@mail.gmail.com>

On Mon, 15 Dec 2014 15:10:38 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> If the driver cannot do SG, perhaps this block should be removed from
> drivers/media/platform/marvell-ccic/mcam-core.h?
> 
>     #if IS_ENABLED(CONFIG_VIDEOBUF2_DMA_SG)
>     #define MCAM_MODE_DMA_SG 1
>     #endif

Other drivers using the Marvell core can do S/G, though, so that option
needs to remain.  Applying your patch is almost certainly the most
straightforward solution at this point.

Thanks,

jon

      reply	other threads:[~2014-12-15 14:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-15 13:55 [PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG Geert Uytterhoeven
2014-12-15 14:04 ` Jonathan Corbet
2014-12-15 14:10   ` Geert Uytterhoeven
2014-12-15 14:13     ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141215091356.3f03f0d7@lwn.net \
    --to=corbet@lwn.net \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox