From: Sakari Ailus <sakari.ailus@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: smiapp-core.c error if !defined(CONFIG_OF)
Date: Tue, 13 Jan 2015 11:35:05 +0200 [thread overview]
Message-ID: <20150113093504.GE17565@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20150113093135.GD17565@valkosipuli.retiisi.org.uk>
On Tue, Jan 13, 2015 at 11:31:35AM +0200, Sakari Ailus wrote:
> Hi Hans,
>
> On Tue, Jan 13, 2015 at 09:54:05AM +0100, Hans Verkuil wrote:
> > Hi Sakari,
> >
> > The daily build fails because of this error:
> >
> > media_build/v4l/smiapp-core.c: In function 'smiapp_get_pdata':
> > media_build/v4l/smiapp-core.c:3061:3: error: implicit declaration of function 'of_read_number' [-Werror=implicit-function-declaration]
> > pdata->op_sys_clock[i] = of_read_number(val + i * 2, 2);
> > ^
> >
> > Some digging showed that of_read_number is only available if CONFIG_OF
> > is defined. As far as I can see that is actually a bug in linux/of.h, as
> > I see no reason why it should be under CONFIG_OF.
>
> Well, it could be defined I guess --- it shouldn't have any use if OF isn't
> in use. I'll submit a patch for that.
Or not. There are a number of functions that are available only if CONFIG_OF
is defined, this is not an only case. If the drivers are happy with that, I
guess it's fine. I think a better solution might be to define a header for
drivers to include.
The issue in the smiapp driver is indeed better fixed by using the right
function to read the 64-bit unsigned integer array.
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
prev parent reply other threads:[~2015-01-13 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 8:54 smiapp-core.c error if !defined(CONFIG_OF) Hans Verkuil
2015-01-13 9:31 ` Sakari Ailus
2015-01-13 9:35 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113093504.GE17565@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox