From: Hans Verkuil <hverkuil@xs4all.nl>
To: linux-media <linux-media@vger.kernel.org>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: smiapp-core.c error if !defined(CONFIG_OF)
Date: Tue, 13 Jan 2015 09:54:05 +0100 [thread overview]
Message-ID: <54B4DD2D.7030303@xs4all.nl> (raw)
Hi Sakari,
The daily build fails because of this error:
media_build/v4l/smiapp-core.c: In function 'smiapp_get_pdata':
media_build/v4l/smiapp-core.c:3061:3: error: implicit declaration of function 'of_read_number' [-Werror=implicit-function-declaration]
pdata->op_sys_clock[i] = of_read_number(val + i * 2, 2);
^
Some digging showed that of_read_number is only available if CONFIG_OF
is defined. As far as I can see that is actually a bug in linux/of.h, as
I see no reason why it should be under CONFIG_OF.
Can you look at this?
Regards,
Hans
next reply other threads:[~2015-01-13 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 8:54 Hans Verkuil [this message]
2015-01-13 9:31 ` smiapp-core.c error if !defined(CONFIG_OF) Sakari Ailus
2015-01-13 9:35 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B4DD2D.7030303@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox