From: Dan Carpenter <dan.carpenter@oracle.com>
To: hverkuil@xs4all.nl
Cc: linux-media@vger.kernel.org
Subject: re: V4L/DVB (6059): ivtv: log stereo/bilingual audio modes
Date: Mon, 18 May 2015 15:31:09 +0300 [thread overview]
Message-ID: <20150518123109.GB32633@mwanda> (raw)
Hello Hans Verkuil,
The patch 25e3f8f40ecf: "V4L/DVB (6059): ivtv: log stereo/bilingual
audio modes" from Aug 19, 2007, leads to the following static checker
warning:
drivers/media/pci/ivtv/ivtv-ioctl.c:1533 ivtv_log_status()
warn: masked condition is always false. '(itv->dualwatch_stereo_mode & ~768) == 512'
drivers/media/pci/ivtv/ivtv-ioctl.c
1529 ivtv_call_all(itv, core, log_status);
1530 ivtv_get_input(itv, itv->active_input, &vidin);
1531 ivtv_get_audio_input(itv, itv->audio_input, &audin);
1532 IVTV_INFO("Video Input: %s\n", vidin.name);
1533 IVTV_INFO("Audio Input: %s%s\n", audin.name,
1534 (itv->dualwatch_stereo_mode & ~0x300) == 0x200 ? " (Bilingual)" : "");
^
Probably this bitwise NOT is a typo? In other words:
(itv->dualwatch_stereo_mode & 0x300) == 0x200 ? " (Bilingual)" : "");
1535 if (has_output) {
regards,
dan carpenter
reply other threads:[~2015-05-18 12:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518123109.GB32633@mwanda \
--to=dan.carpenter@oracle.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox