public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* re: V4L/DVB (6059): ivtv: log stereo/bilingual audio modes
@ 2015-05-18 12:31 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-05-18 12:31 UTC (permalink / raw)
  To: hverkuil; +Cc: linux-media

Hello Hans Verkuil,

The patch 25e3f8f40ecf: "V4L/DVB (6059): ivtv: log stereo/bilingual
audio modes" from Aug 19, 2007, leads to the following static checker
warning:

	drivers/media/pci/ivtv/ivtv-ioctl.c:1533 ivtv_log_status()
	warn: masked condition is always false. '(itv->dualwatch_stereo_mode & ~768) == 512'

drivers/media/pci/ivtv/ivtv-ioctl.c
  1529          ivtv_call_all(itv, core, log_status);
  1530          ivtv_get_input(itv, itv->active_input, &vidin);
  1531          ivtv_get_audio_input(itv, itv->audio_input, &audin);
  1532          IVTV_INFO("Video Input:  %s\n", vidin.name);
  1533          IVTV_INFO("Audio Input:  %s%s\n", audin.name,
  1534                  (itv->dualwatch_stereo_mode & ~0x300) == 0x200 ? " (Bilingual)" : "");
                                                      ^
Probably this bitwise NOT is a typo?  In other words:

			(itv->dualwatch_stereo_mode & 0x300) == 0x200 ? " (Bilingual)" : "");


  1535          if (has_output) {

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-05-18 12:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 12:31 V4L/DVB (6059): ivtv: log stereo/bilingual audio modes Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox