public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* re: [media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver
@ 2015-08-19  8:01 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-08-19  8:01 UTC (permalink / raw)
  To: serjk; +Cc: linux-media

Hello Kozlov Sergey,

The patch 52b1eaf4c59a: "[media] netup_unidvb: NetUP Universal
DVB-S/S2/T/T2/C PCI-E card driver" from Jul 28, 2015, leads to the
following static checker warning:

	drivers/media/pci/netup_unidvb/netup_unidvb_spi.c:84 netup_spi_interrupt()
	error: we previously assumed 'spi' could be null (see line 83)

drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
    78  irqreturn_t netup_spi_interrupt(struct netup_spi *spi)
    79  {
    80          u16 reg;
    81          unsigned long flags;
    82  
    83          if (!spi) {
                    ^^^^
    84                  dev_dbg(&spi->master->dev,
                                ^^^^^^^^^^^^^^^^^
    85                          "%s(): SPI not initialized\n", __func__);
    86                  return IRQ_NONE;
    87          }
    88          spin_lock_irqsave(&spi->lock, flags);


See also:

	drivers/media/pci/netup_unidvb/netup_unidvb_spi.c:238 netup_spi_release()
	error: we previously assumed 'spi' could be null (see line 237)

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-08-19  8:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19  8:01 [media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox