* [PATCH v2] staging: media: Remove unused function atomisp_set_stop_timeout()
@ 2017-03-12 17:10 simran singhal
0 siblings, 0 replies; only message in thread
From: simran singhal @ 2017-03-12 17:10 UTC (permalink / raw)
To: mchehab; +Cc: gregkh, linux-media, devel, linux-kernel, outreachy-kernel, alan
The function atomisp_set_stop_timeout on being called, simply returns
back. The function hasn't been mentioned in the TODO and doesn't have
FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
removed.
This was done using Coccinelle.
@@
identifier f;
@@
void f(...) {
-return;
}
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
v2:
-cc the patch to more developers
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 1 -
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h | 1 -
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c | 5 -----
3 files changed, 7 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
index d9a5c24..9720756 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
@@ -1692,7 +1692,6 @@ void atomisp_wdt_work(struct work_struct *work)
}
}
#endif
- atomisp_set_stop_timeout(ATOMISP_CSS_STOP_TIMEOUT_US);
dev_err(isp->dev, "timeout recovery handling done\n");
atomic_set(&isp->wdt_work_queued, 0);
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h
index e6b0cce..fb8b8fa 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat.h
@@ -660,7 +660,6 @@ int atomisp_css_set_acc_parameters(struct atomisp_acc_fw *acc_fw);
int atomisp_css_isr_thread(struct atomisp_device *isp,
bool *frame_done_found,
bool *css_pipe_done);
-void atomisp_set_stop_timeout(unsigned int timeout);
bool atomisp_css_valid_sof(struct atomisp_device *isp);
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c
index 6697d72..cfa0ad4 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c
@@ -4699,11 +4699,6 @@ int atomisp_css_isr_thread(struct atomisp_device *isp,
return 0;
}
-void atomisp_set_stop_timeout(unsigned int timeout)
-{
- return;
-}
-
bool atomisp_css_valid_sof(struct atomisp_device *isp)
{
unsigned int i, j;
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-12 17:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-12 17:10 [PATCH v2] staging: media: Remove unused function atomisp_set_stop_timeout() simran singhal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox