public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH]
@ 2009-10-29 14:51 flinkdeldinky
  2009-10-29 15:03 ` [PATCH] Jarod Wilson
  0 siblings, 1 reply; 4+ messages in thread
From: flinkdeldinky @ 2009-10-29 14:51 UTC (permalink / raw)
  To: linux-media

The following patch provides functionality for the STLabs PCI card. 
It's a saa7134 card.  I may be the only guy still using it!  I've been
compiling it the code for each kernel I use for years now.

Iif you guys accept this patch you may want to add the following
documentation somewhere (I don't know where to put it):
This card is auto detected as a 10 MOONS card, that doesn't work though.

I load saa7134 as follows:
saa7134 card=175 tuner=5

Everything on the card seems to function and that includes the firewire
port.  I don't know about the remote control though.

Tuners 3, 5, 14, 20, 28, 29, 24, 48 seem to work equally well. Those are
all
the PAL BG tuners. I spot checked several non PAL BG tuners and none worked.


diff -r d6c09c3711b5
linux/drivers/media/video/saa7134/saa7134-cards.c          
--- a/linux/drivers/media/video/saa7134/saa7134-cards.c Sun Sep 20
15:14:21 2009
+0000                                                                        
 
+++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Thu Oct 29
14:54:31 2009
+0700                                                                        
 
@@ -5342,7 +5342,38
@@                                                          
                        .amux   =
LINE2,                                        
                }
},                                                            
       
},                                                                      
-                                                                             
 
+       [SAA7134_BOARD_STLAB_PCI_TV7130] =
{                                    
+       /* "Aidan Gill"
*/                                                      
+               .name = "ST Lab ST Lab PCI-TV7130
",                            
+               .audio_clock =
0x00200000,                                      
+               .tuner_type =
TUNER_LG_PAL_NEW_TAPC,                            
+               .radio_type     =
UNSET,                                        
+               .tuner_addr     =
ADDR_UNSET,                                   
+               .radio_addr     =
ADDR_UNSET,                                   
+               .gpiomask =
0x7000,                                             
+               .inputs =
{{                                                    
+                       .name =
name_tv,                                        
+                       .vmux =
1,                                              
+                       .amux =
LINE2,                                          
+                       .gpio =
0x0000,                                         
+                       .tv =
1,                                                
+               },
{                                                            
+                       .name =
name_comp1,                                     
+                       .vmux =
3,                                              
+                       .amux =
LINE1,                                          
+                       .gpio =
0x2000,                                         
+               },
{                                                            
+                       .name =
name_svideo,                                    
+                       .vmux =
0,                                              
+                       .amux =
LINE1,                                          
+                       .gpio =
0x2000,                                         
+               }
},                                                            
+               .mute =
{                                                       
+                       .name =
name_mute,                                      
+                       .amux =
TV,                                             
+                       .gpio =
0x3000,                                         
+              
},                                                              
+      
},                                                                      
 };                                                                           
 
                                                                              
 
 const unsigned int saa7134_bcount =
ARRAY_SIZE(saa7134_boards);                
@@ -6487,6 +6518,12
@@                                                          
                .subdevice    =
0x4847,                                         
                .driver_data  =
SAA7134_BOARD_ASUS_EUROPA_HYBRID,               
        },
{                                                                    
+               .vendor       =
PCI_VENDOR_ID_PHILIPS,                          
+               .device       =
PCI_DEVICE_ID_PHILIPS_SAA7130,                  
+               .subvendor    = 
PCI_VENDOR_ID_PHILIPS,                         
+               .subdevice    = 0x2001,
+               .driver_data  = SAA7134_BOARD_STLAB_PCI_TV7130,
+       }, {
                /* --- boards without eeprom + subsystem ID --- */
                .vendor       = PCI_VENDOR_ID_PHILIPS,
                .device       = PCI_DEVICE_ID_PHILIPS_SAA7134,
diff -r d6c09c3711b5 linux/drivers/media/video/saa7134/saa7134.h
--- a/linux/drivers/media/video/saa7134/saa7134.h       Sun Sep 20
15:14:21 2009 +0000
+++ b/linux/drivers/media/video/saa7134/saa7134.h       Thu Oct 29
14:54:31 2009 +0700
@@ -299,6 +299,7 @@
 #define SAA7134_BOARD_ROVERMEDIA_LINK_PRO_FM 172
 #define SAA7134_BOARD_ZOLID_HYBRID_PCI         173
 #define SAA7134_BOARD_ASUS_EUROPA_HYBRID       174
+#define SAA7134_BOARD_STLAB_PCI_TV7130         175

 #define SAA7134_MAXBOARDS 32
 #define SAA7134_INPUT_MAX 8

Signed-off-by: Michael Wellman <flinkdeldinky@gmail.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]
  2009-10-29 14:51 [PATCH] flinkdeldinky
@ 2009-10-29 15:03 ` Jarod Wilson
  0 siblings, 0 replies; 4+ messages in thread
From: Jarod Wilson @ 2009-10-29 15:03 UTC (permalink / raw)
  To: flinkdeldinky; +Cc: linux-media

On Oct 29, 2009, at 10:51 AM, flinkdeldinky wrote:

> The following patch provides functionality for the STLabs PCI card.
> It's a saa7134 card.

The patch is also horribly mangled by line-wrapping. Please resubmit  
it without the line wrapping, and with a useful subject.


> I may be the only guy still using it!  I've been
> compiling it the code for each kernel I use for years now.
>
> Iif you guys accept this patch you may want to add the following
> documentation somewhere (I don't know where to put it):
> This card is auto detected as a 10 MOONS card, that doesn't work  
> though.
>
> I load saa7134 as follows:
> saa7134 card=175 tuner=5
>
> Everything on the card seems to function and that includes the  
> firewire
> port.  I don't know about the remote control though.
>
> Tuners 3, 5, 14, 20, 28, 29, 24, 48 seem to work equally well. Those  
> are
> all
> the PAL BG tuners. I spot checked several non PAL BG tuners and none  
> worked.
>
>
> diff -r d6c09c3711b5
> linux/drivers/media/video/saa7134/saa7134-cards.c
> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c Sun Sep 20
> 15:14:21 2009
> +0000
>
> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Thu Oct 29
> 14:54:31 2009
> +0700
>
> @@ -5342,7 +5342,38
> @@
>                        .amux   =
> LINE2,
>                }
> },
>
> },
> -
>
> +       [SAA7134_BOARD_STLAB_PCI_TV7130] =
> {
> +       /* "Aidan Gill"
> */
> +               .name = "ST Lab ST Lab PCI-TV7130
> ",
> +               .audio_clock =
> 0x00200000,
> +               .tuner_type =
> TUNER_LG_PAL_NEW_TAPC,
> +               .radio_type     =
> UNSET,
> +               .tuner_addr     =
> ADDR_UNSET,
> +               .radio_addr     =
> ADDR_UNSET,
> +               .gpiomask =
> 0x7000,
> +               .inputs =
> {{
> +                       .name =
> name_tv,
> +                       .vmux =
> 1,
> +                       .amux =
> LINE2,
> +                       .gpio =
> 0x0000,
> +                       .tv =
> 1,
> +               },
> {
> +                       .name =
> name_comp1,
> +                       .vmux =
> 3,
> +                       .amux =
> LINE1,
> +                       .gpio =
> 0x2000,
> +               },
> {
> +                       .name =
> name_svideo,
> +                       .vmux =
> 0,
> +                       .amux =
> LINE1,
> +                       .gpio =
> 0x2000,
> +               }
> },
> +               .mute =
> {
> +                       .name =
> name_mute,
> +                       .amux =
> TV,
> +                       .gpio =
> 0x3000,
> +
> },
> +
> },
> };
>
>
>
> const unsigned int saa7134_bcount =
> ARRAY_SIZE(saa7134_boards);
> @@ -6487,6 +6518,12
> @@
>                .subdevice    =
> 0x4847,
>                .driver_data  =
> SAA7134_BOARD_ASUS_EUROPA_HYBRID,
>        },
> {
> +               .vendor       =
> PCI_VENDOR_ID_PHILIPS,
> +               .device       =
> PCI_DEVICE_ID_PHILIPS_SAA7130,
> +               .subvendor    =
> PCI_VENDOR_ID_PHILIPS,
> +               .subdevice    = 0x2001,
> +               .driver_data  = SAA7134_BOARD_STLAB_PCI_TV7130,
> +       }, {
>                /* --- boards without eeprom + subsystem ID --- */
>                .vendor       = PCI_VENDOR_ID_PHILIPS,
>                .device       = PCI_DEVICE_ID_PHILIPS_SAA7134,
> diff -r d6c09c3711b5 linux/drivers/media/video/saa7134/saa7134.h
> --- a/linux/drivers/media/video/saa7134/saa7134.h       Sun Sep 20
> 15:14:21 2009 +0000
> +++ b/linux/drivers/media/video/saa7134/saa7134.h       Thu Oct 29
> 14:54:31 2009 +0700
> @@ -299,6 +299,7 @@
> #define SAA7134_BOARD_ROVERMEDIA_LINK_PRO_FM 172
> #define SAA7134_BOARD_ZOLID_HYBRID_PCI         173
> #define SAA7134_BOARD_ASUS_EUROPA_HYBRID       174
> +#define SAA7134_BOARD_STLAB_PCI_TV7130         175
>
> #define SAA7134_MAXBOARDS 32
> #define SAA7134_INPUT_MAX 8
>
> Signed-off-by: Michael Wellman <flinkdeldinky@gmail.com>

-- 
Jarod Wilson
jarod@wilsonet.com




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH]
@ 2017-07-09 23:35 armetallica
  2017-07-20 15:06 ` [PATCH] Mauro Carvalho Chehab
  0 siblings, 1 reply; 4+ messages in thread
From: armetallica @ 2017-07-09 23:35 UTC (permalink / raw)
  To: mchehab, gregkh; +Cc: linux-media, devel, linux-kernel

From 043428d63637a6dd8e52449b73dbb8341885d7e4 Mon Sep 17 00:00:00 2001
From: Armin Schoenlieb <armetallica@gmail.com>
Date: Mon, 10 Jul 2017 01:12:52 +0200
Subject: [PATCH] Staging: media: atomisp2: fixed trailing whitespace error in
 atomisp_v4l2.c This is a patch to the atomisp_v4l2.c file that fixes up a
 trailing whitespace error found by the checkpatch.pl tool

Signed-off-by: Armin Schoenlieb <armetallica@gmail.com>
---
 drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
index a543def739fc..05d02ebb6d25 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
@@ -1277,13 +1277,13 @@ static int atomisp_pci_probe(struct pci_dev *dev,
 			(ATOMISP_HW_REVISION_ISP2400
 			 << ATOMISP_HW_REVISION_SHIFT) |
 			ATOMISP_HW_STEPPING_B0;
-#ifdef FIXME			
+#ifdef FIXME
 		if (INTEL_MID_BOARD(3, TABLET, BYT, BLK, PRO, CRV2) ||
 			INTEL_MID_BOARD(3, TABLET, BYT, BLK, ENG, CRV2)) {
 			isp->dfs = &dfs_config_byt_cr;
 			isp->hpll_freq = HPLL_FREQ_2000MHZ;
 		} else
-#endif		
+#endif
 		{
 			isp->dfs = &dfs_config_byt;
 			isp->hpll_freq = HPLL_FREQ_1600MHZ;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH]
  2017-07-09 23:35 [PATCH] armetallica
@ 2017-07-20 15:06 ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2017-07-20 15:06 UTC (permalink / raw)
  To: armetallica; +Cc: mchehab, gregkh, linux-media, devel, linux-kernel

Em Mon, 10 Jul 2017 01:35:11 +0200
armetallica <armetallica@gmail.com> escreveu:

> From 043428d63637a6dd8e52449b73dbb8341885d7e4 Mon Sep 17 00:00:00 2001
> From: Armin Schoenlieb <armetallica@gmail.com>
> Date: Mon, 10 Jul 2017 01:12:52 +0200
> Subject: [PATCH] Staging: media: atomisp2: fixed trailing whitespace error in
>  atomisp_v4l2.c This is a patch to the atomisp_v4l2.c file that fixes up a
>  trailing whitespace error found by the checkpatch.pl tool

Something clearly gets wrong here...

Regards,
Mauro

> 
> Signed-off-by: Armin Schoenlieb <armetallica@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
> index a543def739fc..05d02ebb6d25 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c
> @@ -1277,13 +1277,13 @@ static int atomisp_pci_probe(struct pci_dev *dev,
>  			(ATOMISP_HW_REVISION_ISP2400
>  			 << ATOMISP_HW_REVISION_SHIFT) |
>  			ATOMISP_HW_STEPPING_B0;
> -#ifdef FIXME			
> +#ifdef FIXME
>  		if (INTEL_MID_BOARD(3, TABLET, BYT, BLK, PRO, CRV2) ||
>  			INTEL_MID_BOARD(3, TABLET, BYT, BLK, ENG, CRV2)) {
>  			isp->dfs = &dfs_config_byt_cr;
>  			isp->hpll_freq = HPLL_FREQ_2000MHZ;
>  		} else
> -#endif		
> +#endif
>  		{
>  			isp->dfs = &dfs_config_byt;
>  			isp->hpll_freq = HPLL_FREQ_1600MHZ;



Thanks,
Mauro

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-07-20 15:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-09 23:35 [PATCH] armetallica
2017-07-20 15:06 ` [PATCH] Mauro Carvalho Chehab
  -- strict thread matches above, loose matches on Subject: below --
2009-10-29 14:51 [PATCH] flinkdeldinky
2009-10-29 15:03 ` [PATCH] Jarod Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox