* [PATCH] [media] solo6x10: hide unused variable
@ 2017-09-15 19:52 Arnd Bergmann
2017-09-15 23:36 ` Ismael Luceno
2017-09-16 10:53 ` Anton Sviridenko
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-09-15 19:52 UTC (permalink / raw)
To: Bluecherry Maintainers, Anton Sviridenko, Andrey Utkin,
Ismael Luceno, Mauro Carvalho Chehab
Cc: Arnd Bergmann, Hans Verkuil, linux-media, linux-kernel
When building without CONFIG_GPIOLIB, we get a harmless
warning about an unused variable:
drivers/media/pci/solo6x10/solo6x10-gpio.c: In function 'solo_gpio_init':
drivers/media/pci/solo6x10/solo6x10-gpio.c:165:6: error: unused variable 'ret' [-Werror=unused-variable]
This adds another #ifdef around the declaration.
Fixes: d3202d1981dc ("media: solo6x10: export hardware GPIO pins 8:31 to gpiolib interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/pci/solo6x10/solo6x10-gpio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci/solo6x10/solo6x10-gpio.c
index 3d0d1aa2f6a8..7b4641a2cb84 100644
--- a/drivers/media/pci/solo6x10/solo6x10-gpio.c
+++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c
@@ -162,7 +162,9 @@ static void solo_gpiochip_set(struct gpio_chip *chip,
int solo_gpio_init(struct solo_dev *solo_dev)
{
+#ifdef CONFIG_GPIOLIB
int ret;
+#endif
solo_gpio_config(solo_dev);
#ifdef CONFIG_GPIOLIB
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] [media] solo6x10: hide unused variable
2017-09-15 19:52 [PATCH] [media] solo6x10: hide unused variable Arnd Bergmann
@ 2017-09-15 23:36 ` Ismael Luceno
2017-09-16 10:53 ` Anton Sviridenko
1 sibling, 0 replies; 3+ messages in thread
From: Ismael Luceno @ 2017-09-15 23:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bluecherry Maintainers, Anton Sviridenko, Andrey Utkin,
Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel
On 15/Sep/2017 21:52, Arnd Bergmann wrote:
> When building without CONFIG_GPIOLIB, we get a harmless
> warning about an unused variable:
>
> drivers/media/pci/solo6x10/solo6x10-gpio.c: In function 'solo_gpio_init':
> drivers/media/pci/solo6x10/solo6x10-gpio.c:165:6: error: unused variable 'ret' [-Werror=unused-variable]
>
> This adds another #ifdef around the declaration.
>
> Fixes: d3202d1981dc ("media: solo6x10: export hardware GPIO pins 8:31 to gpiolib interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/pci/solo6x10/solo6x10-gpio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci/solo6x10/solo6x10-gpio.c
> index 3d0d1aa2f6a8..7b4641a2cb84 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-gpio.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c
> @@ -162,7 +162,9 @@ static void solo_gpiochip_set(struct gpio_chip *chip,
>
> int solo_gpio_init(struct solo_dev *solo_dev)
> {
> +#ifdef CONFIG_GPIOLIB
> int ret;
> +#endif
>
> solo_gpio_config(solo_dev);
> #ifdef CONFIG_GPIOLIB
> --
> 2.9.0
>
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [media] solo6x10: hide unused variable
2017-09-15 19:52 [PATCH] [media] solo6x10: hide unused variable Arnd Bergmann
2017-09-15 23:36 ` Ismael Luceno
@ 2017-09-16 10:53 ` Anton Sviridenko
1 sibling, 0 replies; 3+ messages in thread
From: Anton Sviridenko @ 2017-09-16 10:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bluecherry Maintainers, Ismael Luceno, Andrey Utkin,
Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel
On Fri, Sep 15, 2017 at 09:52:04PM +0200, Arnd Bergmann wrote:
> When building without CONFIG_GPIOLIB, we get a harmless
> warning about an unused variable:
>
> drivers/media/pci/solo6x10/solo6x10-gpio.c: In function 'solo_gpio_init':
> drivers/media/pci/solo6x10/solo6x10-gpio.c:165:6: error: unused variable 'ret' [-Werror=unused-variable]
>
> This adds another #ifdef around the declaration.
>
> Fixes: d3202d1981dc ("media: solo6x10: export hardware GPIO pins 8:31 to gpiolib interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/pci/solo6x10/solo6x10-gpio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci/solo6x10/solo6x10-gpio.c
> index 3d0d1aa2f6a8..7b4641a2cb84 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-gpio.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c
> @@ -162,7 +162,9 @@ static void solo_gpiochip_set(struct gpio_chip *chip,
>
> int solo_gpio_init(struct solo_dev *solo_dev)
> {
> +#ifdef CONFIG_GPIOLIB
> int ret;
> +#endif
>
> solo_gpio_config(solo_dev);
> #ifdef CONFIG_GPIOLIB
> --
> 2.9.0
>
Acked-by: Anton Sviridenko <anton@corp.bluecherry.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-16 10:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-15 19:52 [PATCH] [media] solo6x10: hide unused variable Arnd Bergmann
2017-09-15 23:36 ` Ismael Luceno
2017-09-16 10:53 ` Anton Sviridenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox