Re: [GIT PULL FOR v4.15] Cleanup fixes

[Mauro Carvalho Chehab <mchehab@s-opensource.com>]

Em Fri, 8 Sep 2017 16:34:56 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> coccinelle, checkpatch, coverity, etc. etc.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit 1efdf1776e2253b77413c997bed862410e4b6aaf:
> 
>   media: leds: as3645a: add V4L2_FLASH_LED_CLASS dependency (2017-09-05 16:32:45 -0400)
> 
> are available in the git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git for-v4.15a
> 
> for you to fetch changes up to d50cd4ba25f6a9b5cfd7012cbe0d8c146212cda1:
> 
>   media: cx23885: make const array buf static, reduces object code size (2017-09-08 16:13:36 +0200)
> 
> ----------------------------------------------------------------
> Bhumika Goyal (2):
>       usb: make i2c_client const
>       pci: make i2c_client const
> 
> Colin Ian King (5):
>       rtl28xxu: make array rc_nec_tab static const
>       cx25840: make array stds static const, reduces object code size
>       cobalt: remove redundant zero check on retval
>       ov9640: make const arrays res_x/y static const, reduces object code size
>       media: cx23885: make const array buf static, reduces object code size
> 
> Daniel Scheller (1):
>       dvb-frontends/mxl5xx: declare LIST_HEAD(mxllist) static
> 
> Markus Elfring (62):
>       Cypress: Delete an error message for a failed memory allocation in cypress_load_firmware()
>       Cypress: Improve a size determination in cypress_load_firmware()
>       Siano: Delete an error message for a failed memory allocation in three functions
>       Siano: Improve a size determination in six functions
>       Siano: Adjust five checks for null pointers
>       zr364xx: Delete an error message for a failed memory allocation in two functions
>       zr364xx: Improve a size determination in zr364xx_probe()
>       zr364xx: Adjust ten checks for null pointers
>       as102_fe: Delete an error message for a failed memory allocation in as102_attach()
>       as102_fe: Improve a size determination in as102_attach()
>       cx24113: Delete an error message for a failed memory allocation in cx24113_attach()
>       cx24113: Return directly after a failed kzalloc() in cx24113_attach()
>       cx24113: Improve a size determination in cx24113_attach()
>       cx24116: Delete an error message for a failed memory allocation in cx24116_writeregN()
>       cx24116: Return directly after a failed kmalloc() in cx24116_writeregN()
>       cx24116: Delete an unnecessary variable initialisation in cx24116_writeregN()
>       cx24116: Improve a size determination in cx24116_attach()
>       cx24116: Delete an unnecessary variable initialisation in cx24116_attach()
>       cx24116: Delete jump targets in cx24116_attach()
>       drxd: Delete an error message for a failed memory allocation in load_firmware()
>       drxd: Adjust a null pointer check in three functions
>       ds3000: Delete an error message for a failed memory allocation in two functions
>       ds3000: Improve a size determination in ds3000_attach()
>       ds3000: Delete an unnecessary variable initialisation in ds3000_attach()
>       ds3000: Delete jump targets in ds3000_attach()
>       mb86a20s: Delete an error message for a failed memory allocation in mb86a20s_attach()
>       mb86a20s: Improve a size determination in mb86a20s_attach()
>       mb86a20s: Delete a jump target in mb86a20s_attach()
>       si2168: Delete an error message for a failed memory allocation in si2168_probe()
>       sp2: Delete an error message for a failed memory allocation in sp2_probe()
>       sp2: Improve a size determination in sp2_probe()
>       sp2: Adjust three null pointer checks in sp2_exit()
>       adv7604: Delete an error message for a failed memory allocation in adv76xx_probe()
>       adv7604: Adjust a null pointer check in three functions
>       adv7842: Delete an error message for a failed memory allocation in adv7842_probe()
>       adv7842: Improve a size determination in adv7842_probe()
>       cx18: Delete an error message for a failed memory allocation in cx18_probe()
>       cx18: Improve a size determination in cx18_probe()
>       cx18: Adjust ten checks for null pointers
>       Hopper: Delete an error message for a failed memory allocation in hopper_pci_probe()
>       Hopper: Improve a size determination in hopper_pci_probe()
>       Hopper: Adjust a null pointer check in two functions
>       Hopper: Delete an unnecessary variable initialisation in hopper_pci_probe()
>       Mantis: Delete an error message for a failed memory allocation in mantis_pci_probe()
>       Mantis: Improve a size determination in mantis_pci_probe()
>       Mantis: Delete an unnecessary variable initialisation in mantis_pci_probe()
>       meye: Delete three error messages for a failed memory allocation in meye_probe()
>       meye: Adjust two function calls together with a variable assignment
>       saa7164: Delete an error message for a failed memory allocation in saa7164_buffer_alloc()
>       saa7164: Improve a size determination in two functions
>       Hexium Gemini: Delete an error message for a failed memory allocation in hexium_attach()
>       Hexium Gemini: Improve a size determination in hexium_attach()
>       Hexium Orion: Delete an error message for a failed memory allocation in hexium_probe()
>       Hexium Orion: Improve a size determination in hexium_probe()
>       Hexium Orion: Adjust one function call together with a variable assignment
>       atmel-isc: Delete an error message for a failed memory allocation in isc_formats_init()
>       atmel-isc: Improve a size determination in isc_formats_init()
>       atmel-isc: Adjust three checks for null pointers
>       atmel-isi: Delete an error message for a failed memory allocation in two functions
>       atmel-isi: Improve three size determinations
>       atmel-isi: Adjust a null pointer check in three functions
>       blackfin: Delete an error message for a failed memory allocation in ppi_create_instance()

It **really** doesn't makes any sense to send patch bombs like that!
That pisses me off, as it requires a considerable amount of time from
my side that could be used handling important stuff...

You're even doing the same logical change on the same driver several times,
like this one:
	atmel-isc: Delete an error message for a failed memory allocation in isc_formats_init()
	atmel-isi: Delete an error message for a failed memory allocation in two functions

Please, never do this again. Instead, group patches that do the same
thing per subsystem.

This time, I was nice and I took some time doing:

	$ quilt fold < `quilt next` && quilt delete `quilt next`

In order to merge the same logic change altogether, applied to all
drivers at the subsystem.

Next time, I'll just ignore the hole crap.

Regards,
Mauro