Re: [GIT PULL FOR v4.15] Cleanup fixes

[Mauro Carvalho Chehab <mchehab@s-opensource.com>]

Em Sat, 23 Sep 2017 16:43:53 +0200
SF Markus Elfring <elfring@users.sourceforge.net> escreveu:

> >> coccinelle, checkpatch, coverity, etc.  
> …
> > It **really** doesn't makes any sense to send patch bombs like that!  
> 
> I got an other impression for this software development aspect.
> 
> 
> > That pisses me off, as it requires a considerable amount of time from
> > my side that could be used handling important stuff...  
> 
> I can partly understand this view.
> 
> 
> > You're even doing the same logical change on the same driver several times,
> > like this one:
> > 	atmel-isc: Delete an error message for a failed memory allocation in isc_formats_init()
> > 	atmel-isi: Delete an error message for a failed memory allocation in two functions  
> 
> Such a change approach can occasionally occur because of my selection
> for a specific patch granularity.

Then change patch granularity: one patch per subsystem or per
directory (e. g. pci, usb, platform, others).

> 
> > Instead, group patches that do the same thing per subsystem.  
> 
> I was also uncertain about the acceptance for the suggested
> change patterns.

That's the usual criteria most maintainers use for cleanups.

> Do you want a “development pause” from my queue of change possibilities?

Those patches are mainly source code "polishing". I really don't
want to take much time handling such kind of patches, as they
usually doesn't fix any real bug, nor add functionality.

So, if you really want to contribute, the best is to buy yourself
some media devices, test them and send patches fixing real bugs
and improving the functionality of them.

Regards,
Mauro