broken build against 4.4.0

broken build against 4.4.0

[Vincent McIntyre]

Hi,
can someone take a look please?

+ uname -a
Linux ubuntu 4.4.0-97-generic #120-Ubuntu SMP Tue Sep 19 17:28:18 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
+ cat /proc/version_signature
Ubuntu 4.4.0-97.120-generic 4.4.87

This was with a fresh clone,

+ git --no-pager log -1
commit c93534951f5d66bef7f17f16293acf2be346b726
Author: Jasmin Jessich <jasmin@anw.at>
Date:   Sat Oct 14 01:41:32 2017 +0200

    build: Fixed patches for Kernel 2.6.35
    
    Signed-off-by: Jasmin Jessich <jasmin@anw.at>
    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>

...

make[2]: Leaving directory '/home/me/git/clones/media_build/linux'
make -C /lib/modules/4.4.0-97-generic/build SUBDIRS=/home/me/git/clones/media_buildmodules
make[2]: Entering directory '/usr/src/linux-headers-4.4.0-97-generic'
  CC [M]  /home/me/git/clones/media_build/v4l/msp3400-driver.o
  CC [M]  /home/me/git/clones/media_build/v4l/msp3400-kthreads.o
  LD [M]  /home/me/git/clones/media_build/v4l/msp3400.o
  CC [M]  /home/me/git/clones/media_build/v4l/smiapp-core.o
  CC [M]  /home/me/git/clones/media_build/v4l/smiapp-regs.o
  CC [M]  /home/me/git/clones/media_build/v4l/smiapp-quirk.o
  CC [M]  /home/me/git/clones/media_build/v4l/smiapp-limits.o
  LD [M]  /home/me/git/clones/media_build/v4l/smiapp.o
  CC [M]  /home/me/git/clones/media_build/v4l/et8ek8_mode.o
  CC [M]  /home/me/git/clones/media_build/v4l/et8ek8_driver.o
  LD [M]  /home/me/git/clones/media_build/v4l/et8ek8.o
  CC [M]  /home/me/git/clones/media_build/v4l/cx25840-core.o
  CC [M]  /home/me/git/clones/media_build/v4l/cx25840-audio.o
  CC [M]  /home/me/git/clones/media_build/v4l/cx25840-firmware.o
  CC [M]  /home/me/git/clones/media_build/v4l/cx25840-vbi.o
  CC [M]  /home/me/git/clones/media_build/v4l/cx25840-ir.o
  LD [M]  /home/me/git/clones/media_build/v4l/cx25840.o
  CC [M]  /home/me/git/clones/media_build/v4l/m5mols_core.o
  CC [M]  /home/me/git/clones/media_build/v4l/m5mols_controls.o
  CC [M]  /home/me/git/clones/media_build/v4l/m5mols_capture.o
  LD [M]  /home/me/git/clones/media_build/v4l/m5mols.o
  CC [M]  /home/me/git/clones/media_build/v4l/imx074.o
  CC [M]  /home/me/git/clones/media_build/v4l/mt9m001.o
  CC [M]  /home/me/git/clones/media_build/v4l/mt9t031.o
  CC [M]  /home/me/git/clones/media_build/v4l/mt9t112.o
  CC [M]  /home/me/git/clones/media_build/v4l/mt9v022.o
  CC [M]  /home/me/git/clones/media_build/v4l/ov5642.o
  CC [M]  /home/me/git/clones/media_build/v4l/ov772x.o
  CC [M]  /home/me/git/clones/media_build/v4l/ov9640.o
  CC [M]  /home/me/git/clones/media_build/v4l/ov9740.o
  CC [M]  /home/me/git/clones/media_build/v4l/rj54n1cb0c.o
  CC [M]  /home/me/git/clones/media_build/v4l/tw9910.o
  CC [M]  /home/me/git/clones/media_build/v4l/aptina-pll.o
  CC [M]  /home/me/git/clones/media_build/v4l/tvaudio.o
/home/me/git/clones/media_build/v4l/tvaudio.c: In function 'chip_thread_wake':
/home/me/git/clones/media_build/v4l/tvaudio.c:305:27: error: implicit declaration of function 'from_timer' [-Werror=implicit-function-declaration]
  struct CHIPSTATE *chip = from_timer(chip, t, wt);
                           ^
/home/me/git/clones/media_build/v4l/tvaudio.c:305:47: error: 'wt' undeclared (first use in this function)
  struct CHIPSTATE *chip = from_timer(chip, t, wt);
                                               ^
/home/me/git/clones/media_build/v4l/tvaudio.c:305:47: note: each undeclared identifier is reported only once for each function it appears in
/home/me/git/clones/media_build/v4l/tvaudio.c: In function 'tvaudio_probe':
/home/me/git/clones/media_build/v4l/tvaudio.c:1998:2: error: implicit declaration of function 'timer_setup' [-Werror=implicit-function-declaration]
  timer_setup(&chip->wt, chip_thread_wake, 0);
  ^
cc1: some warnings being treated as errors
scripts/Makefile.build:264: recipe for target '/home/me/git/clones/media_build/v4l/o.o' failed
make[3]: *** [/home/me/git/clones/media_build/v4l/tvaudio.o] Error 1
Makefile:1423: recipe for target '_module_/home/me/git/clones/media_build/v4l' fail
make[2]: *** [_module_/home/me/git/clones/media_build/v4l] Error 2
make[2]: Leaving directory '/usr/src/linux-headers-4.4.0-97-generic'
Makefile:51: recipe for target 'default' failed
make[1]: *** [default] Error 2
make[1]: Leaving directory '/home/me/git/clones/media_build/v4l'
Makefile:26: recipe for target 'all' failed
make: *** [all] Error 2
build failed at ./build line 526

Re: broken build against 4.4.0

[Jasmin J.]

Hello Vincent!

> can someone take a look please?
Well, Matthias may have fixed that (I didn't try).

See:
  https://www.mail-archive.com/linux-media@vger.kernel.org/msg121610.html

Maybe you need that also:
  https://www.mail-archive.com/linux-media@vger.kernel.org/msg121625.html

BR,
   Jasmin

Re: broken build against 4.4.0

[Vincent McIntyre]

On Sun, Nov 05, 2017 at 01:55:22PM +0100, Jasmin J. wrote:
> Hello Vincent!
> 
> > can someone take a look please?
> Well, Matthias may have fixed that (I didn't try).
> 
> See:
>   https://www.mail-archive.com/linux-media@vger.kernel.org/msg121610.html
> 
> Maybe you need that also:
>   https://www.mail-archive.com/linux-media@vger.kernel.org/msg121625.html
> 

It seems Hans applied this a couple of hours ago - thank you Hans!
The build completes just fine now.

Cheers
Vince