From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 2/2] media: staging: atomisp: cleanup whitespaces
Date: Mon, 8 Jan 2018 14:26:39 +0000 [thread overview]
Message-ID: <20180108142639.5ac53fe1@alans-desktop> (raw)
In-Reply-To: <20180108142121.wsinvtmhngokhpp7@paasikivi.fi.intel.com>
On Mon, 8 Jan 2018 16:21:21 +0200
Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
> Hi Mauro,
>
> On Thu, Jan 04, 2018 at 02:44:41PM -0500, Mauro Carvalho Chehab wrote:
> > There are lots of bad whitespaces at atomisp driver.
> >
> > Fix them.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> > ---
> >
> > Sakari/Alan,
> >
> > This is a script-generated patch that can be re-generated anytime.
> > If you prefer to not touch on it now, i'm perfectly fine.
> >
> > I'm sending it just as completeness, as I'm doing a similar
> > cleanup under drivers/media, where a number of <TAB><SPACE>
> > sequences accumulated over the time.
>
> Thanks for the patch.
>
> In principle this is a worthwhile patch; I'd postpone it for the time being
> though: I understand that a few people are bisecting and / or applying
> out-of-tree patches to the driver to debug it on a few different hardware
> platforms. Let's wait until that work is done, and then apply this.
Given the kind of debug going on and the amount of time it's taking (plus
AtomISP for reasons people now know got mostly dropped from my work queue
since June) I'm happy if they get applied.
Can we apply the core ISP2401 merge from Vincent first though ?
Alan
next prev parent reply other threads:[~2018-01-08 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 19:44 [PATCH 1/2] media: staging: use tabs instead of spaces at Kconfig and davinci Mauro Carvalho Chehab
[not found] ` <ab42c265e347855bb95809ef03e043653ab84a21.1515091119.git.mchehab@s-opensource.com>
2018-01-08 14:21 ` [PATCH 2/2] media: staging: atomisp: cleanup whitespaces Sakari Ailus
2018-01-08 14:26 ` Alan Cox [this message]
2018-01-09 22:50 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108142639.5ac53fe1@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@s-opensource.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox