[PATCH 1/2] media: staging: use tabs instead of spaces at Kconfig and davinci

[PATCH 1/2] media: staging: use tabs instead of spaces at Kconfig and davinci

[Mauro Carvalho Chehab]

Even on text and Kconfigs, what we do on media is to use
tabs for indentation.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
 drivers/staging/media/Kconfig           | 14 +++++++-------
 drivers/staging/media/davinci_vpfe/TODO | 10 +++++-----
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig
index 227437f22acf..e68e1d343d53 100644
--- a/drivers/staging/media/Kconfig
+++ b/drivers/staging/media/Kconfig
@@ -1,19 +1,19 @@
 menuconfig STAGING_MEDIA
-        bool "Media staging drivers"
-        default n
-        ---help---
-          This option allows you to select a number of media drivers that
+	bool "Media staging drivers"
+	default n
+	---help---
+	  This option allows you to select a number of media drivers that
 	  don't have the "normal" Linux kernel quality level.
 	  Most of them don't follow properly the V4L, DVB and/or RC API's,
 	  so, they won't likely work fine with the existing applications.
 	  That also means that, once fixed, their API's will change to match
 	  the existing ones.
 
-          If you wish to work on these drivers, to help improve them, or
-          to report problems you have with them, please use the
+	  If you wish to work on these drivers, to help improve them, or
+	  to report problems you have with them, please use the
 	  linux-media@vger.kernel.org mailing list.
 
-          If in doubt, say N here.
+	  If in doubt, say N here.
 
 
 if STAGING_MEDIA && MEDIA_SUPPORT
diff --git a/drivers/staging/media/davinci_vpfe/TODO b/drivers/staging/media/davinci_vpfe/TODO
index 7015ab35ded5..3e5477e8cfa5 100644
--- a/drivers/staging/media/davinci_vpfe/TODO
+++ b/drivers/staging/media/davinci_vpfe/TODO
@@ -2,11 +2,11 @@ TODO (general):
 ==================================
 
 - User space interface refinement
-        - Controls should be used when possible rather than private ioctl
-        - No enums should be used
-        - Use of MC and V4L2 subdev APIs when applicable
-        - Single interface header might suffice
-        - Current interface forces to configure everything at once
+	- Controls should be used when possible rather than private ioctl
+	- No enums should be used
+	- Use of MC and V4L2 subdev APIs when applicable
+	- Single interface header might suffice
+	- Current interface forces to configure everything at once
 - Get rid of the dm365_ipipe_hw.[ch] layer
 - Active external sub-devices defined by link configuration; no strcmp
   needed
-- 
2.14.3

Re: [PATCH 2/2] media: staging: atomisp: cleanup whitespaces

[Sakari Ailus]

Hi Mauro,

On Thu, Jan 04, 2018 at 02:44:41PM -0500, Mauro Carvalho Chehab wrote:
> There are lots of bad whitespaces at atomisp driver.
> 
> Fix them.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> ---
> 
> Sakari/Alan,
> 
> This is a script-generated patch that can be re-generated anytime.
> If you prefer to not touch on it now, i'm perfectly fine.
> 
> I'm sending it just as completeness, as I'm doing a similar
> cleanup under drivers/media, where  a number of <TAB><SPACE>
> sequences accumulated over the time. 

Thanks for the patch.

In principle this is a worthwhile patch; I'd postpone it for the time being
though: I understand that a few people are bisecting and / or applying
out-of-tree patches to the driver to debug it on a few different hardware
platforms. Let's wait until that work is done, and then apply this.

-- 
Kind regards,

Sakari Ailus
sakari.ailus@linux.intel.com

Re: [PATCH 2/2] media: staging: atomisp: cleanup whitespaces

[Alan Cox]

On Mon, 8 Jan 2018 16:21:21 +0200
Sakari Ailus <sakari.ailus@linux.intel.com> wrote:

> Hi Mauro,
> 
> On Thu, Jan 04, 2018 at 02:44:41PM -0500, Mauro Carvalho Chehab wrote:
> > There are lots of bad whitespaces at atomisp driver.
> > 
> > Fix them.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> > ---
> > 
> > Sakari/Alan,
> > 
> > This is a script-generated patch that can be re-generated anytime.
> > If you prefer to not touch on it now, i'm perfectly fine.
> > 
> > I'm sending it just as completeness, as I'm doing a similar
> > cleanup under drivers/media, where  a number of <TAB><SPACE>
> > sequences accumulated over the time.   
> 
> Thanks for the patch.
> 
> In principle this is a worthwhile patch; I'd postpone it for the time being
> though: I understand that a few people are bisecting and / or applying
> out-of-tree patches to the driver to debug it on a few different hardware
> platforms. Let's wait until that work is done, and then apply this.

Given the kind of debug going on and the amount of time it's taking (plus
AtomISP for reasons people now know got mostly dropped from my work queue
since June) I'm happy if they get applied.

Can we apply the core ISP2401 merge from Vincent first though ?

Alan

Re: [PATCH 2/2] media: staging: atomisp: cleanup whitespaces

[Sakari Ailus]

Hi Alan,

On Mon, Jan 08, 2018 at 02:26:39PM +0000, Alan Cox wrote:
> On Mon, 8 Jan 2018 16:21:21 +0200
> Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
> 
> > Hi Mauro,
> > 
> > On Thu, Jan 04, 2018 at 02:44:41PM -0500, Mauro Carvalho Chehab wrote:
> > > There are lots of bad whitespaces at atomisp driver.
> > > 
> > > Fix them.
> > > 
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> > > ---
> > > 
> > > Sakari/Alan,
> > > 
> > > This is a script-generated patch that can be re-generated anytime.
> > > If you prefer to not touch on it now, i'm perfectly fine.
> > > 
> > > I'm sending it just as completeness, as I'm doing a similar
> > > cleanup under drivers/media, where  a number of <TAB><SPACE>
> > > sequences accumulated over the time.   
> > 
> > Thanks for the patch.
> > 
> > In principle this is a worthwhile patch; I'd postpone it for the time being
> > though: I understand that a few people are bisecting and / or applying
> > out-of-tree patches to the driver to debug it on a few different hardware
> > platforms. Let's wait until that work is done, and then apply this.
> 
> Given the kind of debug going on and the amount of time it's taking (plus
> AtomISP for reasons people now know got mostly dropped from my work queue
> since June) I'm happy if they get applied.
> 
> Can we apply the core ISP2401 merge from Vincent first though ?

I'm not sure which patches do you mean here --- there are no recent atomisp
patches from Vincent I'm aware of.

-- 
Regards,

Sakari Ailus
sakari.ailus@linux.intel.com