From: Oliver Neukum <oneukum@suse.com>
To: mchehab@s-opensource.com, ben.hutchings@codethink.co.uk,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org
Cc: Oliver Neukum <oneukum@suse.com>, stable@vger.kernel.org
Subject: [PATCH] [Patch v2] usbtv: Fix refcounting mixup
Date: Tue, 15 May 2018 15:07:44 +0200 [thread overview]
Message-ID: <20180515130744.19342-1-oneukum@suse.com> (raw)
The premature free in the error path is blocked by V4L
refcounting, not USB refcounting. Thanks to
Ben Hutchings for review.
[v2] corrected attributions
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Fixes: 50e704453553 ("media: usbtv: prevent double free in error case")
CC: stable@vger.kernel.org
Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
---
drivers/media/usb/usbtv/usbtv-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/usbtv/usbtv-core.c b/drivers/media/usb/usbtv/usbtv-core.c
index 5095c380b2c1..4a03c4d66314 100644
--- a/drivers/media/usb/usbtv/usbtv-core.c
+++ b/drivers/media/usb/usbtv/usbtv-core.c
@@ -113,7 +113,8 @@ static int usbtv_probe(struct usb_interface *intf,
usbtv_audio_fail:
/* we must not free at this point */
- usb_get_dev(usbtv->udev);
+ v4l2_device_get(&usbtv->v4l2_dev);
+ /* this will undo the v4l2_device_get() */
usbtv_video_free(usbtv);
usbtv_video_fail:
--
2.13.6
next reply other threads:[~2018-05-15 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 13:07 Oliver Neukum [this message]
2018-05-15 14:28 ` [PATCH] [Patch v2] usbtv: Fix refcounting mixup Hans Verkuil
2018-05-15 15:46 ` Oliver Neukum
2018-05-15 16:01 ` Hans Verkuil
2018-05-16 9:23 ` Oliver Neukum
2018-05-16 10:27 ` Hans Verkuil
2020-09-16 13:47 ` Oliver Neukum
2020-09-21 9:10 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515130744.19342-1-oneukum@suse.com \
--to=oneukum@suse.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox