* [PATCH] dma-buf: Remove requirement for ops->map() from dma_buf_export
@ 2018-08-07 18:36 Chris Wilson
2018-08-07 19:02 ` Daniel Vetter
2018-08-10 6:01 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2018-08-07 18:36 UTC (permalink / raw)
To: dri-devel
Cc: linux-media, linaro-mm-sig, intel-gfx, Chris Wilson,
Daniel Vetter, Gerd Hoffmann, Sumit Semwal
Since commit 9ea0dfbf972 ("dma-buf: make map_atomic and map function
pointers optional"), the core provides the no-op functions when map and
map_atomic are not provided, so we no longer need assert that are
supplied by a dma-buf exporter.
Fixes: 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
---
drivers/dma-buf/dma-buf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 13884474d158..02f7f9a89979 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -405,7 +405,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info)
|| !exp_info->ops->map_dma_buf
|| !exp_info->ops->unmap_dma_buf
|| !exp_info->ops->release
- || !exp_info->ops->map
|| !exp_info->ops->mmap)) {
return ERR_PTR(-EINVAL);
}
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dma-buf: Remove requirement for ops->map() from dma_buf_export
2018-08-07 18:36 [PATCH] dma-buf: Remove requirement for ops->map() from dma_buf_export Chris Wilson
@ 2018-08-07 19:02 ` Daniel Vetter
2018-08-10 6:01 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2018-08-07 19:02 UTC (permalink / raw)
To: Chris Wilson
Cc: dri-devel, linux-media, linaro-mm-sig, intel-gfx, Daniel Vetter,
Gerd Hoffmann, Sumit Semwal
On Tue, Aug 07, 2018 at 07:36:47PM +0100, Chris Wilson wrote:
> Since commit 9ea0dfbf972 ("dma-buf: make map_atomic and map function
> pointers optional"), the core provides the no-op functions when map and
> map_atomic are not provided, so we no longer need assert that are
> supplied by a dma-buf exporter.
>
> Fixes: 09ea0dfbf972 ("dma-buf: make map_atomic and map function pointers optional")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
Ooops.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/dma-buf/dma-buf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index 13884474d158..02f7f9a89979 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -405,7 +405,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info)
> || !exp_info->ops->map_dma_buf
> || !exp_info->ops->unmap_dma_buf
> || !exp_info->ops->release
> - || !exp_info->ops->map
> || !exp_info->ops->mmap)) {
> return ERR_PTR(-EINVAL);
> }
> --
> 2.18.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dma-buf: Remove requirement for ops->map() from dma_buf_export
2018-08-07 18:36 [PATCH] dma-buf: Remove requirement for ops->map() from dma_buf_export Chris Wilson
2018-08-07 19:02 ` Daniel Vetter
@ 2018-08-10 6:01 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2018-08-10 6:01 UTC (permalink / raw)
To: Chris Wilson
Cc: dri-devel, linux-media, linaro-mm-sig, intel-gfx, Daniel Vetter,
Sumit Semwal
On Tue, Aug 07, 2018 at 07:36:47PM +0100, Chris Wilson wrote:
> Since commit 9ea0dfbf972 ("dma-buf: make map_atomic and map function
> pointers optional"), the core provides the no-op functions when map and
> map_atomic are not provided, so we no longer need assert that are
> supplied by a dma-buf exporter.
Pushed to drm-misc-next.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-10 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-07 18:36 [PATCH] dma-buf: Remove requirement for ops->map() from dma_buf_export Chris Wilson
2018-08-07 19:02 ` Daniel Vetter
2018-08-10 6:01 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox