Re: [PATCH v2 2/3] media: staging: rkisp1: use v4l2_pipeline_stream_{enable,disable} helpers

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4227 bytes --]

Hi Helen,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.6 next-20200404]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Helen-Koike/media-add-v4l2_pipeline_stream_-enable-disable-helpers/20200405-050004
base:   git://linuxtv.org/media_tree.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/staging/media/rkisp1/rkisp1-capture.c: In function 'rkisp1_vb2_start_streaming':
>> drivers/staging/media/rkisp1/rkisp1-capture.c:952:31: error: passing argument 1 of 'v4l2_pipeline_stream_disable' from incompatible pointer type [-Werror=incompatible-pointer-types]
     952 |  v4l2_pipeline_stream_disable(entity, &cap->rkisp1->pipe);
         |                               ^~~~~~
         |                               |
         |                               struct media_entity *
   In file included from drivers/staging/media/rkisp1/rkisp1-capture.c:13:
   include/media/v4l2-common.h:548:56: note: expected 'struct video_device *' but argument is of type 'struct media_entity *'
     548 | void v4l2_pipeline_stream_disable(struct video_device *vdev);
         |                                   ~~~~~~~~~~~~~~~~~~~~~^~~~
>> drivers/staging/media/rkisp1/rkisp1-capture.c:952:2: error: too many arguments to function 'v4l2_pipeline_stream_disable'
     952 |  v4l2_pipeline_stream_disable(entity, &cap->rkisp1->pipe);
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/staging/media/rkisp1/rkisp1-capture.c:13:
   include/media/v4l2-common.h:548:6: note: declared here
     548 | void v4l2_pipeline_stream_disable(struct video_device *vdev);
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/v4l2_pipeline_stream_disable +952 drivers/staging/media/rkisp1/rkisp1-capture.c

   913	
   914	static int
   915	rkisp1_vb2_start_streaming(struct vb2_queue *queue, unsigned int count)
   916	{
   917		struct rkisp1_capture *cap = queue->drv_priv;
   918		struct media_entity *entity = &cap->vnode.vdev.entity;
   919		int ret;
   920	
   921		ret = rkisp1_dummy_buf_create(cap);
   922		if (ret)
   923			goto err_ret_buffers;
   924	
   925		ret = pm_runtime_get_sync(cap->rkisp1->dev);
   926		if (ret) {
   927			dev_err(cap->rkisp1->dev, "power up failed %d\n", ret);
   928			goto err_destroy_dummy;
   929		}
   930		ret = v4l2_pipeline_pm_get(entity);
   931		if (ret) {
   932			dev_err(cap->rkisp1->dev, "open cif pipeline failed %d\n", ret);
   933			goto err_pipe_pm_put;
   934		}
   935	
   936		rkisp1_stream_start(cap);
   937	
   938		/* start sub-devices */
   939		ret = v4l2_pipeline_stream_enable(&cap->vnode.vdev);
   940		if (ret)
   941			goto err_stop_stream;
   942	
   943		ret = media_pipeline_start(entity, &cap->rkisp1->pipe);
   944		if (ret) {
   945			dev_err(cap->rkisp1->dev, "start pipeline failed %d\n", ret);
   946			goto err_pipe_disable;
   947		}
   948	
   949		return 0;
   950	
   951	err_pipe_disable:
 > 952		v4l2_pipeline_stream_disable(entity, &cap->rkisp1->pipe);
   953	err_stop_stream:
   954		rkisp1_stream_stop(cap);
   955		v4l2_pipeline_pm_put(entity);
   956	err_pipe_pm_put:
   957		pm_runtime_put(cap->rkisp1->dev);
   958	err_destroy_dummy:
   959		rkisp1_dummy_buf_destroy(cap);
   960	err_ret_buffers:
   961		rkisp1_return_all_buffers(cap, VB2_BUF_STATE_QUEUED);
   962	
   963		return ret;
   964	}
   965	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53907 bytes --]