From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bingbu Cao <bingbu.cao@linux.intel.com>,
Yong Zhi <yong.zhi@intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1] media: ipu3-cio2: Use macros from mm.h
Date: Fri, 30 Oct 2020 01:10:23 +0200 [thread overview]
Message-ID: <20201029231023.GO26150@paasikivi.fi.intel.com> (raw)
In-Reply-To: <CAHp75VfnFQZhZ1nFPNzgu-fn+yzmUNvwEVkoAk-=GXYvkxEy4w@mail.gmail.com>
On Fri, Oct 30, 2020 at 01:06:30AM +0200, Andy Shevchenko wrote:
> On Fri, Oct 30, 2020 at 12:12 AM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> > On Thu, Oct 29, 2020 at 10:16:57PM +0200, Andy Shevchenko wrote:
> > > On Wed, Oct 28, 2020 at 04:11:05PM +0800, Bingbu Cao wrote:
>
> ...
>
> > > I just realized I can rewrite this as:
> > >
> > > remaining = offset_in_page(remaining) ?: PAGE_SIZE;
> > > entry[1].second_entry.last_page_available_bytes = remaining - 1;
> > >
> > > Would it work for you?
> >
> > Looks good to me.
>
> Have you got v2?
Yes, in fact. I'll check it tomorrow / some time next week.
--
Sakari Ailus
next prev parent reply other threads:[~2020-10-29 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 20:16 [PATCH v1] media: ipu3-cio2: Use macros from mm.h Andy Shevchenko
2020-10-29 22:08 ` Sakari Ailus
2020-10-29 23:06 ` Andy Shevchenko
2020-10-29 23:10 ` Sakari Ailus [this message]
2020-10-30 2:01 ` Cao, Bingbu
-- strict thread matches above, loose matches on Subject: below --
2020-10-27 18:14 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029231023.GO26150@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox