From: "Cao, Bingbu" <bingbu.cao@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Yong Zhi <yong.zhi@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
linux-media@vger.kernel.org, Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1] media: ipu3-cio2: Use macros from mm.h
Date: Fri, 30 Oct 2020 10:01:58 +0800 [thread overview]
Message-ID: <61584879-babd-6a95-2cbb-c160ccb45351@linux.intel.com> (raw)
In-Reply-To: <20201029201657.GE4077@smile.fi.intel.com>
On 10/30/20 4:16 AM, Andy Shevchenko wrote:
> On Wed, Oct 28, 2020 at 04:11:05PM +0800, Bingbu Cao wrote:
>> Andy, thanks for your patch.
>
>> Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
>
> Thanks!
>
>> On 10/28/20 2:14 AM, Andy Shevchenko wrote:
>
>>> - entry[1].second_entry.last_page_available_bytes =
>>> - (remaining & ~PAGE_MASK) ?
>>> - (remaining & ~PAGE_MASK) - 1 : PAGE_SIZE - 1;
>>> + remaining = offset_in_page(remaining);
>>> + entry[1].second_entry.last_page_available_bytes = (remaining ?: PAGE_SIZE) - 1;
>>
>> Not really about this change, is there some coding style update? This line obviously over 80
>> chars, but the latest script did not report warning.
>
> There is a relaxation in the script, but now it's ambiguous with the documentation.
> I just realized I can rewrite this as:
>
> remaining = offset_in_page(remaining) ?: PAGE_SIZE;
> entry[1].second_entry.last_page_available_bytes = remaining - 1;
>
> Would it work for you?
Yes, looks good for me, thanks.
>
>>> /* Fill FBPT */
>>> remaining = length;
>>> i = 0;
>
--
Best regards,
Bingbu Cao
next prev parent reply other threads:[~2020-10-30 2:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 20:16 [PATCH v1] media: ipu3-cio2: Use macros from mm.h Andy Shevchenko
2020-10-29 22:08 ` Sakari Ailus
2020-10-29 23:06 ` Andy Shevchenko
2020-10-29 23:10 ` Sakari Ailus
2020-10-30 2:01 ` Cao, Bingbu [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-27 18:14 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61584879-babd-6a95-2cbb-c160ccb45351@linux.intel.com \
--to=bingbu.cao@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox