* [GIT PULL FOR v5.16] Allegro fixes/enhancements
@ 2021-10-11 8:49 Hans Verkuil
2021-10-11 9:38 ` [GIT PULL FOR v5.16] Allegro fixes/enhancements (#77656) Jenkins
2021-10-18 8:40 ` [GIT PULL FOR v5.16] Allegro fixes/enhancements Mauro Carvalho Chehab
0 siblings, 2 replies; 4+ messages in thread
From: Hans Verkuil @ 2021-10-11 8:49 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Michael Tretter
The following changes since commit fd2eda71a47b095e81b9170c3f8b7ae82b04e785:
media: remove myself from dvb media maintainers (2021-10-08 13:56:25 +0200)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16i
for you to fetch changes up to 8f472ea73758255b366fae57bde772396231efcd:
media: allegro: write vui parameters for HEVC (2021-10-11 10:18:33 +0200)
----------------------------------------------------------------
Tag branch
----------------------------------------------------------------
Michael Tretter (13):
media: allegro: ignore interrupt if mailbox is not initialized
media: allegro: fix module removal if initialization failed
media: allegro: lookup VCU settings
media: allegro: add pm_runtime support
media: allegro: add encoder buffer support
media: allegro: add control to disable encoder buffer
media: allegro: fix row and column in response message
media: allegro: remove external QP table
media: allegro: correctly scale the bit rate in SPS
media: allegro: extract nal value lookup functions to header
media: allegro: write correct colorspace into SPS
media: allegro: nal-hevc: implement generator for vui
media: allegro: write vui parameters for HEVC
drivers/media/platform/allegro-dvt/allegro-core.c | 311 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
drivers/media/platform/allegro-dvt/allegro-mail.c | 23 +++---
drivers/media/platform/allegro-dvt/allegro-mail.h | 10 ++-
drivers/media/platform/allegro-dvt/nal-h264.c | 74 -----------------
drivers/media/platform/allegro-dvt/nal-h264.h | 200 +++++++++++++++++++++++++++++++++++++++++++-
drivers/media/platform/allegro-dvt/nal-hevc.c | 202 +++++++++++++++++++++++++++++----------------
drivers/media/platform/allegro-dvt/nal-hevc.h | 189 +++++++++++++++++++++++++++++++++++++++---
include/uapi/linux/v4l2-controls.h | 5 ++
8 files changed, 811 insertions(+), 203 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [GIT PULL FOR v5.16] Allegro fixes/enhancements (#77656)
2021-10-11 8:49 [GIT PULL FOR v5.16] Allegro fixes/enhancements Hans Verkuil
@ 2021-10-11 9:38 ` Jenkins
2021-10-18 8:40 ` [GIT PULL FOR v5.16] Allegro fixes/enhancements Mauro Carvalho Chehab
1 sibling, 0 replies; 4+ messages in thread
From: Jenkins @ 2021-10-11 9:38 UTC (permalink / raw)
To: mchehab+samsung, linux-media; +Cc: builder
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/710cddfc-e3c3-0cf3-d2f9-c38ef6ca8b1a@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/147010/
Build time: 00:41:54
Link: https://lore.kernel.org/linux-media/710cddfc-e3c3-0cf3-d2f9-c38ef6ca8b1a@xs4all.nl
gpg: Signature made Mon 11 Oct 2021 08:44:58 AM UTC
gpg: using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [unknown]
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F 1BCA BD2D 6148 6614 3B4C
Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE A142 1326 E0CD 23AB DCE5
Summary: got 5/13 patches with issues, being 5 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-media-allegro-ignore-interrupt-if-mailbox-is-not-ini.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
allyesconfig: return code #0:
../drivers/media/cec/core/cec-adap.c: ../drivers/media/cec/core/cec-adap.c:926 cec_transmit_msg_fh() warn: '&data->list' not removed from list
../drivers/media/rc/meson-ir-tx.c:22: warning: expecting prototype for meson(). Prototype was for DEVICE_NAME() instead
SPARSE:../drivers/media/rc/ir_toy.c ../drivers/media/rc/ir_toy.c:321:20: warning: incorrect type in assignment (different base types)
SPARSE:../drivers/media/rc/ir_toy.c ../drivers/media/rc/ir_toy.c:321:20: expected restricted __be16 [usertype]
SPARSE:../drivers/media/rc/ir_toy.c ../drivers/media/rc/ir_toy.c:321:20: got int
../drivers/media/pci/intel/ipu3/cio2-bridge.c:242 cio2_bridge_connect_sensor() warn: missing error code 'ret'
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
../drivers/media/usb/pvrusb2/pvrusb2-encoder.c: ../drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:1730 pvr2_hdw_set_streaming() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3461 pvr2_hdw_cpufw_set_enabled() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3501 pvr2_hdw_cpufw_get() warn: inconsistent indenting
patches/0006-media-allegro-add-control-to-disable-encoder-buffer.patch:
allyesconfig: return code #0:
../drivers/media/pci/intel/ipu3/cio2-bridge.c:242 cio2_bridge_connect_sensor() warn: missing error code 'ret'
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds
../drivers/media/usb/pvrusb2/pvrusb2-encoder.c: ../drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:1730 pvr2_hdw_set_streaming() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3461 pvr2_hdw_cpufw_set_enabled() warn: inconsistent indenting
../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3501 pvr2_hdw_cpufw_get() warn: inconsistent indenting
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2900 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
checkpatch.pl:
$ cat patches/0006-media-allegro-add-control-to-disable-encoder-buffer.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:115: CHECK: Alignment should match open parenthesis
patches/0010-media-allegro-extract-nal-value-lookup-functions-to-.patch:
allyesconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
allmodconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
patches/0011-media-allegro-write-correct-colorspace-into-SPS.patch:
allyesconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
allmodconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
patches/0012-media-allegro-nal-hevc-implement-generator-for-vui.patch:
allyesconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
allmodconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [../scripts/Makefile.build:277: drivers/media/platform/allegro-dvt/nal-hevc.o] Error 1
make[4]: *** [../scripts/Makefile.build:540: drivers/media/platform/allegro-dvt] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [../scripts/Makefile.build:540: drivers/media/platform] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [../scripts/Makefile.build:540: drivers/media] Error 2
make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1868: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
Error #512 when building PDF docs
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [GIT PULL FOR v5.16] Allegro fixes/enhancements
2021-10-11 8:49 [GIT PULL FOR v5.16] Allegro fixes/enhancements Hans Verkuil
2021-10-11 9:38 ` [GIT PULL FOR v5.16] Allegro fixes/enhancements (#77656) Jenkins
@ 2021-10-18 8:40 ` Mauro Carvalho Chehab
2021-10-18 9:12 ` Hans Verkuil
1 sibling, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2021-10-18 8:40 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List, Michael Tretter
Em Mon, 11 Oct 2021 10:49:14 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> The following changes since commit fd2eda71a47b095e81b9170c3f8b7ae82b04e785:
>
> media: remove myself from dvb media maintainers (2021-10-08 13:56:25 +0200)
>
> are available in the Git repository at:
>
> git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16i
>
> for you to fetch changes up to 8f472ea73758255b366fae57bde772396231efcd:
>
> media: allegro: write vui parameters for HEVC (2021-10-11 10:18:33 +0200)
>
> ----------------------------------------------------------------
> Tag branch
>
> ----------------------------------------------------------------
> Michael Tretter (13):
> media: allegro: ignore interrupt if mailbox is not initialized
> media: allegro: fix module removal if initialization failed
> media: allegro: lookup VCU settings
> media: allegro: add pm_runtime support
> media: allegro: add encoder buffer support
> media: allegro: add control to disable encoder buffer
> media: allegro: fix row and column in response message
> media: allegro: remove external QP table
> media: allegro: correctly scale the bit rate in SPS
> media: allegro: extract nal value lookup functions to header
> media: allegro: write correct colorspace into SPS
> media: allegro: nal-hevc: implement generator for vui
> media: allegro: write vui parameters for HEVC
Jenkins is reporting compilation breakage when -Werror is turned on:
patches/0010-media-allegro-extract-nal-value-lookup-functions-to-.patch:
allyesconfig: return code #512:
In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible
Are there any missing include?
Regards,
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [GIT PULL FOR v5.16] Allegro fixes/enhancements
2021-10-18 8:40 ` [GIT PULL FOR v5.16] Allegro fixes/enhancements Mauro Carvalho Chehab
@ 2021-10-18 9:12 ` Hans Verkuil
0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2021-10-18 9:12 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Linux Media Mailing List, Michael Tretter
Hi Mauro,
On 18/10/2021 10:40, Mauro Carvalho Chehab wrote:
> Em Mon, 11 Oct 2021 10:49:14 +0200
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
>
>> The following changes since commit fd2eda71a47b095e81b9170c3f8b7ae82b04e785:
>>
>> media: remove myself from dvb media maintainers (2021-10-08 13:56:25 +0200)
>>
>> are available in the Git repository at:
>>
>> git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16i
>>
>> for you to fetch changes up to 8f472ea73758255b366fae57bde772396231efcd:
>>
>> media: allegro: write vui parameters for HEVC (2021-10-11 10:18:33 +0200)
>>
>> ----------------------------------------------------------------
>> Tag branch
>>
>> ----------------------------------------------------------------
>> Michael Tretter (13):
>> media: allegro: ignore interrupt if mailbox is not initialized
>> media: allegro: fix module removal if initialization failed
>> media: allegro: lookup VCU settings
>> media: allegro: add pm_runtime support
>> media: allegro: add encoder buffer support
>> media: allegro: add control to disable encoder buffer
>> media: allegro: fix row and column in response message
>> media: allegro: remove external QP table
>> media: allegro: correctly scale the bit rate in SPS
>> media: allegro: extract nal value lookup functions to header
>> media: allegro: write correct colorspace into SPS
>> media: allegro: nal-hevc: implement generator for vui
>> media: allegro: write vui parameters for HEVC
>
> Jenkins is reporting compilation breakage when -Werror is turned on:
>
> patches/0010-media-allegro-extract-nal-value-lookup-functions-to-.patch:
>
> allyesconfig: return code #512:
> In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
> ../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> ../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> ../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> ../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> ../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> ../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible
>
> Are there any missing include?
Ah, the next two patches add the necessary videodev2.h includes. I've fixed up the
patch series to add videodev2.h to this patch instead of later patches, and will
post a new PR soon.
Michael, no need for you to do anything.
Regards,
Hans
>
> Regards,
> Mauro
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-18 9:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-11 8:49 [GIT PULL FOR v5.16] Allegro fixes/enhancements Hans Verkuil
2021-10-11 9:38 ` [GIT PULL FOR v5.16] Allegro fixes/enhancements (#77656) Jenkins
2021-10-18 8:40 ` [GIT PULL FOR v5.16] Allegro fixes/enhancements Mauro Carvalho Chehab
2021-10-18 9:12 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox