From: Daniel Scally <djrscally@gmail.com>
To: linux-media@vger.kernel.org, libcamera-devel@lists.libcamera.org
Cc: sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com,
hanlinchen@chromium.org, tfiga@chromium.org, hdegoede@redhat.com,
kieran.bingham@ideasonboard.com, hpa@redhat.com
Subject: [PATCH 2/5] media: entity: Add link_type() helper
Date: Mon, 13 Dec 2021 23:28:46 +0000 [thread overview]
Message-ID: <20211213232849.40071-3-djrscally@gmail.com> (raw)
In-Reply-To: <20211213232849.40071-1-djrscally@gmail.com>
Now we have three types of media link, printing the right name during
debug output is slightly more complicated. Add a helper function to
make it easier.
Signed-off-by: Daniel Scally <djrscally@gmail.com>
---
Changes since the rfc:
- new patch
drivers/media/mc/mc-entity.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
index f40f41977142..d79eb88bc167 100644
--- a/drivers/media/mc/mc-entity.c
+++ b/drivers/media/mc/mc-entity.c
@@ -60,6 +60,20 @@ static inline const char *intf_type(struct media_interface *intf)
}
};
+static inline const char *link_type(struct media_link *link)
+{
+ switch (link->flags & MEDIA_LNK_FL_LINK_TYPE) {
+ case MEDIA_LNK_FL_DATA_LINK:
+ return "data";
+ case MEDIA_LNK_FL_INTERFACE_LINK:
+ return "interface";
+ case MEDIA_LNK_FL_ANCILLARY_LINK:
+ return "ancillary";
+ default:
+ return "unknown";
+ }
+}
+
__must_check int __media_entity_enum_init(struct media_entity_enum *ent_enum,
int idx_max)
{
@@ -107,9 +121,7 @@ static void dev_dbg_obj(const char *event_name, struct media_gobj *gobj)
dev_dbg(gobj->mdev->dev,
"%s id %u: %s link id %u ==> id %u\n",
- event_name, media_id(gobj),
- media_type(link->gobj0) == MEDIA_GRAPH_PAD ?
- "data" : "interface",
+ event_name, media_id(gobj), link_type(link),
media_id(link->gobj0),
media_id(link->gobj1));
break;
--
2.25.1
next prev parent reply other threads:[~2021-12-13 23:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 23:28 [PATCH 0/5] Introduce ancillary links Daniel Scally
2021-12-13 23:28 ` [PATCH 1/5] media: media.h: Add new media link type Daniel Scally
2021-12-14 21:50 ` Laurent Pinchart
2021-12-14 21:52 ` Daniel Scally
2021-12-13 23:28 ` Daniel Scally [this message]
2021-12-14 21:54 ` [PATCH 2/5] media: entity: Add link_type() helper Laurent Pinchart
2021-12-14 21:57 ` Daniel Scally
2021-12-13 23:28 ` [PATCH 3/5] media: entity: Skip non-data links in graph iteration Daniel Scally
2021-12-14 15:01 ` Sakari Ailus
2021-12-14 16:14 ` Daniel Scally
2021-12-14 21:22 ` Sakari Ailus
2021-12-14 21:37 ` Daniel Scally
2021-12-14 22:05 ` Laurent Pinchart
2021-12-13 23:28 ` [PATCH 4/5] media: entity: Add support for ancillary links Daniel Scally
2021-12-14 4:06 ` kernel test robot
2021-12-14 21:25 ` Sakari Ailus
2021-12-14 21:54 ` Daniel Scally
2021-12-14 22:14 ` Laurent Pinchart
2022-01-16 23:52 ` Daniel Scally
2021-12-13 23:28 ` [PATCH 5/5] media: v4l2-async: Create links during v4l2_async_match_notify() Daniel Scally
2021-12-14 22:22 ` Laurent Pinchart
2021-12-14 22:36 ` Daniel Scally
2021-12-14 23:01 ` Laurent Pinchart
2021-12-14 23:41 ` Daniel Scally
2021-12-15 9:04 ` Laurent Pinchart
2021-12-15 9:44 ` Sakari Ailus
2021-12-15 9:55 ` Laurent Pinchart
2021-12-15 23:10 ` Daniel Scally
2021-12-15 23:14 ` Laurent Pinchart
2022-01-16 0:01 ` Daniel Scally
2021-12-16 11:10 ` kernel test robot
2021-12-16 11:14 ` Daniel Scally
2021-12-15 9:25 ` [PATCH 0/5] Introduce ancillary links Mauro Carvalho Chehab
2021-12-15 9:36 ` Daniel Scally
2021-12-15 9:52 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211213232849.40071-3-djrscally@gmail.com \
--to=djrscally@gmail.com \
--cc=hanlinchen@chromium.org \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=libcamera-devel@lists.libcamera.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox