From: Jammy Huang <jammy_huang@aspeedtech.com>
To: <eajames@linux.ibm.com>, <mchehab@kernel.org>, <joel@jms.id.au>,
<andrew@aj.id.au>, <linux-media@vger.kernel.org>,
<openbmc@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/4] media: aspeed: Correct values for detected timing
Date: Fri, 17 Dec 2021 17:54:02 +0800 [thread overview]
Message-ID: <20211217095403.2618-4-jammy_huang@aspeedtech.com> (raw)
In-Reply-To: <20211217095403.2618-1-jammy_huang@aspeedtech.com>
Correct timing's fp/sync/bp value based on the information below.
It should be noticed that the calculation formula should be changed
per sync polarity.
The sequence of signal: sync - backporch - video data - frontporch
The following registers start counting from sync's rising edge:
1. VR090: frame edge's left and right
2. VR094: frame edge's top and bottom
3. VR09C: counting from sync's rising edge to falling edge
+--+ +-------------------+ +--+
| | | v i d e o | | |
+--+ +-----+ +-----+ +---+
sync+--+
left/top+--------+
right/bottom+----------------------------+
+-------------------+
| v i d e o |
+--+ +-----+ +-----+ +---+
| | | |
+--+ +--+
sync+-------------------------------+
left/top+-----+
right/bottom+-------------------------+
Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
---
drivers/media/platform/aspeed-video.c | 27 ++++++++++++++++++++++-----
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
index 581a4261f9b7..5ad3a20c5bac 100644
--- a/drivers/media/platform/aspeed-video.c
+++ b/drivers/media/platform/aspeed-video.c
@@ -988,10 +988,20 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)
src_tb_edge);
video->frame_top = FIELD_GET(VE_SRC_TB_EDGE_DET_TOP,
src_tb_edge);
- det->vfrontporch = video->frame_top;
- det->vbackporch = FIELD_GET(VE_MODE_DETECT_V_LINES, mds) -
- video->frame_bottom;
det->vsync = FIELD_GET(VE_SYNC_STATUS_VSYNC, sync);
+ if (det->polarities & V4L2_DV_VSYNC_POS_POL) {
+ det->vbackporch = video->frame_top - det->vsync;
+ det->vfrontporch =
+ FIELD_GET(VE_MODE_DETECT_V_LINES, mds) -
+ video->frame_bottom;
+ } else {
+ det->vsync = FIELD_GET(VE_MODE_DETECT_V_LINES, mds) -
+ det->vsync;
+ det->vbackporch = video->frame_top;
+ det->vfrontporch =
+ FIELD_GET(VE_MODE_DETECT_V_LINES, mds) -
+ video->frame_bottom - det->vsync;
+ }
if (video->frame_top > video->frame_bottom)
continue;
@@ -999,9 +1009,16 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)
src_lr_edge);
video->frame_left = FIELD_GET(VE_SRC_LR_EDGE_DET_LEFT,
src_lr_edge);
- det->hfrontporch = video->frame_left;
- det->hbackporch = htotal - video->frame_right;
det->hsync = FIELD_GET(VE_SYNC_STATUS_HSYNC, sync);
+ if (det->polarities & V4L2_DV_HSYNC_POS_POL) {
+ det->hbackporch = video->frame_left - det->hsync;
+ det->hfrontporch = htotal - video->frame_right;
+ } else {
+ det->hsync = htotal - det->hsync;
+ det->hbackporch = video->frame_left;
+ det->hfrontporch = htotal - video->frame_right -
+ det->hsync;
+ }
if (video->frame_left > video->frame_right)
continue;
--
2.25.1
next prev parent reply other threads:[~2021-12-17 9:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 9:53 [PATCH 0/4] Correct timing report Jammy Huang
2021-12-17 9:54 ` [PATCH 1/4] media: aspeed: Correct value for h-total-pixels Jammy Huang
2021-12-22 0:54 ` Joel Stanley
2021-12-17 9:54 ` [PATCH 2/4] media: aspeed: Use FIELD_GET to improve readability Jammy Huang
2021-12-22 0:59 ` Joel Stanley
2021-12-22 6:10 ` Jammy Huang
2021-12-17 9:54 ` Jammy Huang [this message]
2021-12-22 1:31 ` [PATCH 3/4] media: aspeed: Correct values for detected timing Joel Stanley
2021-12-22 6:11 ` Jammy Huang
2021-12-17 9:54 ` [PATCH 4/4] media: aspeed: Fix timing polarity incorrect Jammy Huang
2021-12-22 1:22 ` Joel Stanley
2021-12-22 6:10 ` Jammy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217095403.2618-4-jammy_huang@aspeedtech.com \
--to=jammy_huang@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox