Linux Media Controller development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: ming.qian@nxp.com, linux-media@vger.kernel.org
Subject: Re: [bug report] media: amphion: add vpu core driver
Date: Wed, 9 Mar 2022 18:20:33 +0300	[thread overview]
Message-ID: <20220309152033.GY3315@kadam> (raw)
In-Reply-To: <c662ab37-6e47-59f1-0bbc-4003b905f70a@xs4all.nl>

On Wed, Mar 09, 2022 at 02:33:20PM +0100, Hans Verkuil wrote:
> Hi Dan,
> 
> On 3/9/22 11:43, Dan Carpenter wrote:
> > Hello Ming Qian,
> > 
> > The patch 9f599f351e86: "media: amphion: add vpu core driver" from
> > Feb 24, 2022, leads to the following Smatch static checker warning:
> > 
> > 	drivers/media/platform/amphion/vpu_core.c:654 vpu_core_probe()
> > 	warn: pm_runtime_get_sync() also returns 1 on success
> 
> Odd, I didn't get this warning when I ran smatch.

Sorry, I will push this Smatch check tomorrow.  It's simple and has few
false positives.

regards,
dan carpenter


  reply	other threads:[~2022-03-09 15:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 10:43 [bug report] media: amphion: add vpu core driver Dan Carpenter
2022-03-09 10:45 ` Dan Carpenter
2022-03-09 13:33 ` Hans Verkuil
2022-03-09 15:20   ` Dan Carpenter [this message]
2022-03-09 15:43     ` Hans Verkuil
2022-03-10  1:54 ` [EXT] " Ming Qian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220309152033.GY3315@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=ming.qian@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox