From: Arvind Yadav <Arvind.Yadav@amd.com>
To: <Christian.Koenig@amd.com>, <andrey.grodzovsky@amd.com>,
<shashank.sharma@amd.com>, <amaranath.somalapuram@amd.com>,
<Arunpravin.PaneerSelvam@amd.com>, <sumit.semwal@linaro.org>,
<gustavo@padovan.org>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linaro-mm-sig@lists.linaro.org>, <linux-kernel@vger.kernel.org>
Cc: Arvind Yadav <Arvind.Yadav@amd.com>
Subject: [PATCH 1/4] dma-buf: Check status of enable-signaling bit on debug
Date: Mon, 5 Sep 2022 16:26:50 +0530 [thread overview]
Message-ID: <20220905105653.13670-2-Arvind.Yadav@amd.com> (raw)
In-Reply-To: <20220905105653.13670-1-Arvind.Yadav@amd.com>
The core DMA-buf framework needs to enable signaling
before the fence is signaled. The core DMA-buf framework
can forget to enable signaling before the fence is signaled.
To avoid this scenario on the debug kernel, check the
DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT status bit before checking
the signaling bit status to confirm that enable_signaling
is enabled.
Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
---
include/linux/dma-fence.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
index 775cdc0b4f24..60c0e935c0b5 100644
--- a/include/linux/dma-fence.h
+++ b/include/linux/dma-fence.h
@@ -428,6 +428,11 @@ dma_fence_is_signaled_locked(struct dma_fence *fence)
static inline bool
dma_fence_is_signaled(struct dma_fence *fence)
{
+#ifdef CONFIG_DEBUG_FS
+ if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags))
+ return false;
+#endif
+
if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
return true;
--
2.25.1
next prev parent reply other threads:[~2022-09-05 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 10:56 [PATCH 0/4] dma-buf: To check enable signaling before signaled Arvind Yadav
2022-09-05 10:56 ` Arvind Yadav [this message]
2022-09-05 11:21 ` [PATCH 1/4] dma-buf: Check status of enable-signaling bit on debug Christian König
2022-09-05 13:43 ` Yadav, Arvind
2022-09-05 16:39 ` Tvrtko Ursulin
2022-09-05 18:26 ` Christian König
2022-09-05 10:56 ` [PATCH 2/4] drm/sched: Add callback and enable signaling " Arvind Yadav
2022-09-05 11:25 ` Christian König
2022-09-05 13:46 ` Yadav, Arvind
2022-09-05 14:58 ` Yadav, Arvind
2022-09-05 15:32 ` Christian König
2022-09-05 10:56 ` [PATCH 3/4] dma-buf: " Arvind Yadav
2022-09-05 11:26 ` Christian König
2022-09-05 13:50 ` Yadav, Arvind
2022-09-05 10:56 ` [PATCH 4/4] " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905105653.13670-2-Arvind.Yadav@amd.com \
--to=arvind.yadav@amd.com \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=airlied@linux.ie \
--cc=amaranath.somalapuram@amd.com \
--cc=andrey.grodzovsky@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=shashank.sharma@amd.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox