From: Arvind Yadav <Arvind.Yadav@amd.com>
To: <Christian.Koenig@amd.com>, <andrey.grodzovsky@amd.com>,
<shashank.sharma@amd.com>, <amaranath.somalapuram@amd.com>,
<Arunpravin.PaneerSelvam@amd.com>, <sumit.semwal@linaro.org>,
<gustavo@padovan.org>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linaro-mm-sig@lists.linaro.org>, <linux-kernel@vger.kernel.org>
Cc: Arvind Yadav <Arvind.Yadav@amd.com>
Subject: [PATCH 2/4] drm/sched: Add callback and enable signaling on debug
Date: Mon, 5 Sep 2022 16:26:51 +0530 [thread overview]
Message-ID: <20220905105653.13670-3-Arvind.Yadav@amd.com> (raw)
In-Reply-To: <20220905105653.13670-1-Arvind.Yadav@amd.com>
Here's on debug adding an enable_signaling callback for finished
fences and enabling software signaling for finished fence.
Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
---
drivers/gpu/drm/scheduler/sched_fence.c | 12 ++++++++++++
drivers/gpu/drm/scheduler/sched_main.c | 4 +++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/sched_fence.c b/drivers/gpu/drm/scheduler/sched_fence.c
index 7fd869520ef2..ebd26cdb79a0 100644
--- a/drivers/gpu/drm/scheduler/sched_fence.c
+++ b/drivers/gpu/drm/scheduler/sched_fence.c
@@ -122,16 +122,28 @@ static void drm_sched_fence_release_finished(struct dma_fence *f)
dma_fence_put(&fence->scheduled);
}
+#ifdef CONFIG_DEBUG_FS
+static bool drm_sched_enable_signaling(struct dma_fence *f)
+{
+ return true;
+}
+#endif
static const struct dma_fence_ops drm_sched_fence_ops_scheduled = {
.get_driver_name = drm_sched_fence_get_driver_name,
.get_timeline_name = drm_sched_fence_get_timeline_name,
+#ifdef CONFIG_DEBUG_FS
+ .enable_signaling = drm_sched_enable_signaling,
+#endif
.release = drm_sched_fence_release_scheduled,
};
static const struct dma_fence_ops drm_sched_fence_ops_finished = {
.get_driver_name = drm_sched_fence_get_driver_name,
.get_timeline_name = drm_sched_fence_get_timeline_name,
+#ifdef CONFIG_DEBUG_FS
+ .enable_signaling = drm_sched_enable_signaling,
+#endif
.release = drm_sched_fence_release_finished,
};
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index e0ab14e0fb6b..140e3d8646e2 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -961,7 +961,9 @@ static int drm_sched_main(void *param)
s_fence->parent = dma_fence_get(fence);
/* Drop for original kref_init of the fence */
dma_fence_put(fence);
-
+#ifdef CONFIG_DEBUG_FS
+ dma_fence_enable_sw_signaling(&s_fence->finished);
+#endif
r = dma_fence_add_callback(fence, &sched_job->cb,
drm_sched_job_done_cb);
if (r == -ENOENT)
--
2.25.1
next prev parent reply other threads:[~2022-09-05 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 10:56 [PATCH 0/4] dma-buf: To check enable signaling before signaled Arvind Yadav
2022-09-05 10:56 ` [PATCH 1/4] dma-buf: Check status of enable-signaling bit on debug Arvind Yadav
2022-09-05 11:21 ` Christian König
2022-09-05 13:43 ` Yadav, Arvind
2022-09-05 16:39 ` Tvrtko Ursulin
2022-09-05 18:26 ` Christian König
2022-09-05 10:56 ` Arvind Yadav [this message]
2022-09-05 11:25 ` [PATCH 2/4] drm/sched: Add callback and enable signaling " Christian König
2022-09-05 13:46 ` Yadav, Arvind
2022-09-05 14:58 ` Yadav, Arvind
2022-09-05 15:32 ` Christian König
2022-09-05 10:56 ` [PATCH 3/4] dma-buf: " Arvind Yadav
2022-09-05 11:26 ` Christian König
2022-09-05 13:50 ` Yadav, Arvind
2022-09-05 10:56 ` [PATCH 4/4] " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905105653.13670-3-Arvind.Yadav@amd.com \
--to=arvind.yadav@amd.com \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=airlied@linux.ie \
--cc=amaranath.somalapuram@amd.com \
--cc=andrey.grodzovsky@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=shashank.sharma@amd.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox