* [PATCH 1/1] media: staging: atomisp: select V4L2_FWNODE
@ 2023-06-13 16:51 Sakari Ailus
2023-06-13 17:01 ` Andy Shevchenko
2023-06-13 17:08 ` Hans de Goede
0 siblings, 2 replies; 4+ messages in thread
From: Sakari Ailus @ 2023-06-13 16:51 UTC (permalink / raw)
To: linux-media; +Cc: Hans de Goede, Andy Shevchenko
Select V4L2_FWNODE as the driver depends on it.
Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Fixes: aa31f6514047 ("media: atomisp: allow building the driver again")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/staging/media/atomisp/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
index c9bff98e5309a..e9b168ba97bf1 100644
--- a/drivers/staging/media/atomisp/Kconfig
+++ b/drivers/staging/media/atomisp/Kconfig
@@ -13,6 +13,7 @@ config VIDEO_ATOMISP
tristate "Intel Atom Image Signal Processor Driver"
depends on VIDEO_DEV && INTEL_ATOMISP
depends on PMIC_OPREGION
+ select V4L2_FWNODE
select IOSF_MBI
select VIDEOBUF2_VMALLOC
select VIDEO_V4L2_SUBDEV_API
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] media: staging: atomisp: select V4L2_FWNODE
2023-06-13 16:51 [PATCH 1/1] media: staging: atomisp: select V4L2_FWNODE Sakari Ailus
@ 2023-06-13 17:01 ` Andy Shevchenko
2023-06-13 17:06 ` Sakari Ailus
2023-06-13 17:08 ` Hans de Goede
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2023-06-13 17:01 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media, Hans de Goede
On Tue, Jun 13, 2023 at 07:51:09PM +0300, Sakari Ailus wrote:
> Select V4L2_FWNODE as the driver depends on it.
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
I believe this should be @linux.intel.com, but it doesn't matter.
> Fixes: aa31f6514047 ("media: atomisp: allow building the driver again")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/staging/media/atomisp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
> index c9bff98e5309a..e9b168ba97bf1 100644
> --- a/drivers/staging/media/atomisp/Kconfig
> +++ b/drivers/staging/media/atomisp/Kconfig
> @@ -13,6 +13,7 @@ config VIDEO_ATOMISP
> tristate "Intel Atom Image Signal Processor Driver"
> depends on VIDEO_DEV && INTEL_ATOMISP
> depends on PMIC_OPREGION
> + select V4L2_FWNODE
> select IOSF_MBI
> select VIDEOBUF2_VMALLOC
> select VIDEO_V4L2_SUBDEV_API
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] media: staging: atomisp: select V4L2_FWNODE
2023-06-13 17:01 ` Andy Shevchenko
@ 2023-06-13 17:06 ` Sakari Ailus
0 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2023-06-13 17:06 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-media, Hans de Goede
Hi Andy,
On Tue, Jun 13, 2023 at 08:01:14PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 13, 2023 at 07:51:09PM +0300, Sakari Ailus wrote:
> > Select V4L2_FWNODE as the driver depends on it.
>
> Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> > Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> I believe this should be @linux.intel.com, but it doesn't matter.
I can change that before sending the PR. You used you @intel.com e-mail for
sending it, just FYI.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] media: staging: atomisp: select V4L2_FWNODE
2023-06-13 16:51 [PATCH 1/1] media: staging: atomisp: select V4L2_FWNODE Sakari Ailus
2023-06-13 17:01 ` Andy Shevchenko
@ 2023-06-13 17:08 ` Hans de Goede
1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2023-06-13 17:08 UTC (permalink / raw)
To: Sakari Ailus, linux-media, Mauro Carvalho Chehab; +Cc: Andy Shevchenko
Hi,
On 6/13/23 18:51, Sakari Ailus wrote:
> Select V4L2_FWNODE as the driver depends on it.
>
> Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Fixes: aa31f6514047 ("media: atomisp: allow building the driver again")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Mauro this is a build fix for the recent atomisp pull-req
for 6.5, can you merge this please.
Regards,
Hans
> ---
> drivers/staging/media/atomisp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
> index c9bff98e5309a..e9b168ba97bf1 100644
> --- a/drivers/staging/media/atomisp/Kconfig
> +++ b/drivers/staging/media/atomisp/Kconfig
> @@ -13,6 +13,7 @@ config VIDEO_ATOMISP
> tristate "Intel Atom Image Signal Processor Driver"
> depends on VIDEO_DEV && INTEL_ATOMISP
> depends on PMIC_OPREGION
> + select V4L2_FWNODE
> select IOSF_MBI
> select VIDEOBUF2_VMALLOC
> select VIDEO_V4L2_SUBDEV_API
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-13 17:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-13 16:51 [PATCH 1/1] media: staging: atomisp: select V4L2_FWNODE Sakari Ailus
2023-06-13 17:01 ` Andy Shevchenko
2023-06-13 17:06 ` Sakari Ailus
2023-06-13 17:08 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox