Re: [PATCH 1/2] media: Kconfig: imx290: Correct CCI dependency

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

Thank you for the patch.

On Sat, Jul 29, 2023 at 01:40:49PM +0300, Sakari Ailus wrote:
> The Kconfig parts of the original patch converting the IMX290 to use V4L2
> CCI was mis-merged. Correct this.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307271517.dPa1bTSi-lkp@intel.com/
> Fixes: be02a09c84ad ("media: imx290: Convert to new CCI register access helpers")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/i2c/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 24cbf35c6fe1..f3453a5da970 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -125,6 +125,7 @@ config VIDEO_IMX274
>  config VIDEO_IMX290
>  	tristate "Sony IMX290 sensor support"
>  	select REGMAP_I2C

I think you can also drop REGMAP_I2C, as that's now internal to the CCI
helpers.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +	select V4L2_CCI_I2C
>  	help
>  	  This is a Video4Linux2 sensor driver for the Sony
>  	  IMX290 camera sensor.
> @@ -934,7 +935,6 @@ config VIDEO_ADV748X
>  	select VIDEO_V4L2_SUBDEV_API
>  	select REGMAP_I2C
>  	select V4L2_FWNODE
> -	select V4L2_CCI_I2C
>  	help
>  	  V4L2 subdevice driver for the Analog Devices
>  	  ADV7481 and ADV7482 HDMI/Analog video decoders.

-- 
Regards,

Laurent Pinchart