Linux Media Controller development
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] media: Kconfig: imx290: Correct CCI dependency
Date: Sat, 29 Jul 2023 12:51:25 +0200	[thread overview]
Message-ID: <c78392fc-4e97-0f42-0533-40ea4f00d01c@redhat.com> (raw)
In-Reply-To: <20230729104050.1187715-1-sakari.ailus@linux.intel.com>

Hi,

On 7/29/23 12:40, Sakari Ailus wrote:
> The Kconfig parts of the original patch converting the IMX290 to use V4L2
> CCI was mis-merged. Correct this.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307271517.dPa1bTSi-lkp@intel.com/
> Fixes: be02a09c84ad ("media: imx290: Convert to new CCI register access helpers")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Thanks, the series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans

> ---
>  drivers/media/i2c/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 24cbf35c6fe1..f3453a5da970 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -125,6 +125,7 @@ config VIDEO_IMX274
>  config VIDEO_IMX290
>  	tristate "Sony IMX290 sensor support"
>  	select REGMAP_I2C
> +	select V4L2_CCI_I2C
>  	help
>  	  This is a Video4Linux2 sensor driver for the Sony
>  	  IMX290 camera sensor.
> @@ -934,7 +935,6 @@ config VIDEO_ADV748X
>  	select VIDEO_V4L2_SUBDEV_API
>  	select REGMAP_I2C
>  	select V4L2_FWNODE
> -	select V4L2_CCI_I2C
>  	help
>  	  V4L2 subdevice driver for the Analog Devices
>  	  ADV7481 and ADV7482 HDMI/Analog video decoders.


  parent reply	other threads:[~2023-07-29 10:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29 10:40 [PATCH 1/2] media: Kconfig: imx290: Correct CCI dependency Sakari Ailus
2023-07-29 10:40 ` [PATCH 2/2] media: Kconfig: ov5693: " Sakari Ailus
2023-07-29 10:51 ` Hans de Goede [this message]
2023-08-07 13:39 ` [PATCH 1/2] media: Kconfig: imx290: " Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c78392fc-4e97-0f42-0533-40ea4f00d01c@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox