From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, bingbu.cao@intel.com, hverkuil@xs4all.nl
Subject: Re: [PATCH 3/3] media: mc: Drop useless debug print on file handle release
Date: Thu, 21 Dec 2023 18:40:56 +0200 [thread overview]
Message-ID: <20231221164056.GA10901@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20231221135822.152448-4-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Thu, Dec 21, 2023 at 03:58:22PM +0200, Sakari Ailus wrote:
> Drop a debug print in media_release(), which is a release callback for a
> file handle. Printing a debug message here is simply not necessary.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/media/mc/mc-devnode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/mc/mc-devnode.c b/drivers/media/mc/mc-devnode.c
> index 680fbb3a9340..9c8fe9335dc1 100644
> --- a/drivers/media/mc/mc-devnode.c
> +++ b/drivers/media/mc/mc-devnode.c
> @@ -190,7 +190,6 @@ static int media_release(struct inode *inode, struct file *filp)
> return value is ignored. */
> put_device(&devnode->dev);
>
> - pr_debug("%s: Media Release\n", __func__);
> return 0;
> }
>
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2023-12-21 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 13:58 [PATCH 0/3] Miscellaneous small things Sakari Ailus
2023-12-21 13:58 ` [PATCH 1/3] media: ipu3-cio2: Further clean up async subdev link creation Sakari Ailus
2023-12-21 16:57 ` Laurent Pinchart
2023-12-21 18:30 ` Sakari Ailus
2023-12-21 13:58 ` [PATCH 2/3] media: v4l2-mc: Add debug prints for v4l2_fwnode_create_links_for_pad() Sakari Ailus
2023-12-21 16:45 ` Laurent Pinchart
2023-12-21 18:27 ` Sakari Ailus
2023-12-21 13:58 ` [PATCH 3/3] media: mc: Drop useless debug print on file handle release Sakari Ailus
2023-12-21 16:40 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221164056.GA10901@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bingbu.cao@intel.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox