Linux Media Controller development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-media@vger.kernel.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 0/9] media: vimc improvements
Date: Thu, 20 Jun 2024 19:09:59 +0300	[thread overview]
Message-ID: <20240620160959.GG30640@pendragon.ideasonboard.com> (raw)
In-Reply-To: <bb5eb601-a7b6-4c77-afd8-bfabcd8c15d4@linuxfoundation.org>

On Thu, Jun 20, 2024 at 09:59:31AM -0600, Shuah Khan wrote:
> On 4/24/24 17:57, Laurent Pinchart wrote:
> > Hello,
> > 
> > This patch series cleans up and improves the vimc driver, with the end
> > goal of converting it to the V4L2 subdev active state API. The goal of
> > this exercise is to make the API used by a virtual test driver, to
> > increase test coverage.
> > 
> > The series starts with 4 random cleanups, to avoid unnecessary
> > iterations (1/9), constify structures (2/9 and 3/9) and rename a
> > weirdly-named enum (4/9). Patch 5/9 then centralizes the subdev
> > internal_ops initialization to prepare for the switch to the active
> > state API. The remaining patches (6/9 to 9/9) convert the vimc entities
> > to the new API one by one.
> > 
> > The result has been tested using the libcamera unit tests, which make
> > extensive use of the vimc driver, as well as with v4l2-compliance. The
> > latter reports 4 errors, but they occur already with the latest stage
> > master branch.
> > 
> > Laurent Pinchart (9):
> >    media: vimc: Don't iterate over single pad
> >    media: vimc: Constify vimc_ent_type structures
> >    media: vimc: Constify the ent_config array
> >    media: vimc: scaler: Rename vic_sca_pad enum to vimc_scaler_pad
> >    media: vimc: Centralize subdev internal_ops initialization
> >    media: vimc: Initialize subdev active state
> >    media: vimc: sensor: Use subdev active state
> >    media: vimc: debayer: Use subdev active state
> >    media: vimc: scaler: Use subdev active state
> > 
> 
> Thank you. Applied the series to
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=vimc
> 
> I will send pull request to Mauro in a week.

Thank you Shuah. Much appreciated.

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2024-06-20 16:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 23:57 [PATCH v1 0/9] media: vimc improvements Laurent Pinchart
2024-04-24 23:57 ` [PATCH v1 1/9] media: vimc: Don't iterate over single pad Laurent Pinchart
2024-05-30 19:27   ` Shuah Khan
2024-05-30 19:45     ` Laurent Pinchart
2024-05-30 20:18       ` Shuah Khan
2024-05-30 20:21         ` Laurent Pinchart
2024-05-30 20:58           ` Shuah Khan
2024-06-20 10:47           ` Hans Verkuil
2024-06-20 13:00             ` Sakari Ailus
2024-06-20 15:33               ` Shuah Khan
2024-06-20 13:01   ` Sakari Ailus
2024-04-24 23:57 ` [PATCH v1 2/9] media: vimc: Constify vimc_ent_type structures Laurent Pinchart
2024-05-30 19:28   ` Shuah Khan
2024-04-24 23:57 ` [PATCH v1 3/9] media: vimc: Constify the ent_config array Laurent Pinchart
2024-05-30 19:29   ` Shuah Khan
2024-04-24 23:57 ` [PATCH v1 4/9] media: vimc: scaler: Rename vic_sca_pad enum to vimc_scaler_pad Laurent Pinchart
2024-05-30 19:29   ` Shuah Khan
2024-04-24 23:57 ` [PATCH v1 5/9] media: vimc: Centralize subdev internal_ops initialization Laurent Pinchart
2024-05-30 19:31   ` Shuah Khan
2024-04-24 23:57 ` [PATCH v1 6/9] media: vimc: Initialize subdev active state Laurent Pinchart
2024-04-24 23:57 ` [PATCH v1 7/9] media: vimc: sensor: Use " Laurent Pinchart
2024-04-24 23:57 ` [PATCH v1 8/9] media: vimc: debayer: " Laurent Pinchart
2024-04-24 23:57 ` [PATCH v1 9/9] media: vimc: scaler: " Laurent Pinchart
2024-05-05 20:36 ` [PATCH v1 0/9] media: vimc improvements Laurent Pinchart
2024-05-28 15:49   ` Shuah Khan
2024-05-30 19:34 ` Shuah Khan
2024-06-20 15:59 ` Shuah Khan
2024-06-20 16:09   ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240620160959.GG30640@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox