Re: [PATCH v1 1/9] media: vimc: Don't iterate over single pad

[Shuah Khan <skhan@linuxfoundation.org>]

On 5/30/24 13:45, Laurent Pinchart wrote:
> Hi Shuah,
> 
> On Thu, May 30, 2024 at 01:27:53PM -0600, Shuah Khan wrote:
>> On 4/24/24 17:57, Laurent Pinchart wrote:
>>> The .init_state() operations of the debayer and sensor entities iterate
>>> over the entity's pads. In practice, the iteration covers a single pad
>>> only. Access the pad directly and remove the loops.
>>
>> I am not seeing much of a reason to do this. This code is good
>> even when num_pads change.
>>
>> Don't change the loops.
> 
> Why so ? Beside the fact that the loop wastes some CPU cycles, the
> current code implies that there would be multiple source pads, which is
> confusing for the reader. I think the result of this patch is both
> improved efficiency and improved readability.

It is currently flexible and if and when more pads get added,
there is no need to change it. I am not concerned about the
efficiency on this test driver. Also people use the test
driver as a sample.

Please leave it the way it is.

thanks,
-- Shuah