Re: [PATCH v9 9/9] media: v4l: Convert the users of v4l2_get_link_freq to call it on a pad

[kernel test robot <lkp@intel.com>]

Hi Sakari,

kernel test robot noticed the following build errors:

[auto build test ERROR on c4b7779abc6633677e6edb79e2809f4f61fde157]

url:    https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/media-v4l-Support-passing-media-pad-argument-to-v4l2_get_link_freq/20250119-224053
base:   c4b7779abc6633677e6edb79e2809f4f61fde157
patch link:    https://lore.kernel.org/r/20250119143904.114991-10-sakari.ailus%40linux.intel.com
patch subject: [PATCH v9 9/9] media: v4l: Convert the users of v4l2_get_link_freq to call it on a pad
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250120/202501200204.0M82bJgt-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250120/202501200204.0M82bJgt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501200204.0M82bJgt-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/media/platform/qcom/camss/camss.c:14:
   In file included from include/linux/module.h:19:
   In file included from include/linux/elf.h:6:
   In file included from arch/s390/include/asm/elf.h:181:
   In file included from arch/s390/include/asm/mmu_context.h:11:
   In file included from arch/s390/include/asm/pgalloc.h:18:
   In file included from include/linux/mm.h:2223:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/qcom/camss/camss.c:2057:2: error: use of undeclared identifier 'sensor_pad'
    2057 |         sensor_pad = camss_find_sensor_pad(entity);
         |         ^
   drivers/media/platform/qcom/camss/camss.c:2058:7: error: use of undeclared identifier 'sensor_pad'; did you mean 'seq_pad'?
    2058 |         if (!sensor_pad)
         |              ^~~~~~~~~~
         |              seq_pad
   include/linux/seq_file.h:105:6: note: 'seq_pad' declared here
     105 | void seq_pad(struct seq_file *m, char c);
         |      ^
>> drivers/media/platform/qcom/camss/camss.c:2058:7: warning: address of function 'seq_pad' will always evaluate to 'true' [-Wpointer-bool-conversion]
    2058 |         if (!sensor_pad)
         |             ~^~~~~~~~~~
   drivers/media/platform/qcom/camss/camss.c:2058:7: note: prefix with the address-of operator to silence this warning
    2058 |         if (!sensor_pad)
         |              ^
         |              &
   drivers/media/platform/qcom/camss/camss.c:2061:39: error: use of undeclared identifier 'sensor_pad'
    2061 |         subdev = media_entity_to_v4l2_subdev(sensor_pad->entity);
         |                                              ^
   drivers/media/platform/qcom/camss/camss.c:2061:39: error: use of undeclared identifier 'sensor_pad'
   5 warnings and 4 errors generated.


vim +/sensor_pad +2057 drivers/media/platform/qcom/camss/camss.c

  2043	
  2044	/*
  2045	 * camss_get_pixel_clock - Get pixel clock rate from sensor
  2046	 * @entity: Media entity in the current pipeline
  2047	 * @pixel_clock: Received pixel clock value
  2048	 *
  2049	 * Return 0 on success or a negative error code otherwise
  2050	 */
  2051	int camss_get_pixel_clock(struct media_entity *entity, u64 *pixel_clock)
  2052	{
  2053		struct media_pad *sensor;
  2054		struct v4l2_subdev *subdev;
  2055		struct v4l2_ctrl *ctrl;
  2056	
> 2057		sensor_pad = camss_find_sensor_pad(entity);
> 2058		if (!sensor_pad)
  2059			return -ENODEV;
  2060	
  2061		subdev = media_entity_to_v4l2_subdev(sensor_pad->entity);
  2062	
  2063		ctrl = v4l2_ctrl_find(subdev->ctrl_handler, V4L2_CID_PIXEL_RATE);
  2064	
  2065		if (!ctrl)
  2066			return -EINVAL;
  2067	
  2068		*pixel_clock = v4l2_ctrl_g_ctrl_int64(ctrl);
  2069	
  2070		return 0;
  2071	}
  2072	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki