From: kernel test robot <lkp@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Yong Zhi <yong.zhi@intel.com>, Dan Scally <djrscally@gmail.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
bingbu.cao@intel.com, Tianshu Qiu <tian.shu.qiu@intel.com>,
Maxime Ripard <mripard@kernel.org>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Martin Kepplinger <martink@posteo.de>,
Purism Kernel Team <kernel@puri.sm>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Benoit Parrot <bparrot@ti.com>,
Ricardo Ribalda <ribalda@chromium.org>,
"Duc-Long, Le" <duclong.linux@gmail.com>
Subject: Re: [PATCH v9 9/9] media: v4l: Convert the users of v4l2_get_link_freq to call it on a pad
Date: Mon, 20 Jan 2025 02:17:38 +0800 [thread overview]
Message-ID: <202501200228.jk1X695m-lkp@intel.com> (raw)
In-Reply-To: <20250119143904.114991-10-sakari.ailus@linux.intel.com>
Hi Sakari,
kernel test robot noticed the following build warnings:
[auto build test WARNING on c4b7779abc6633677e6edb79e2809f4f61fde157]
url: https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/media-v4l-Support-passing-media-pad-argument-to-v4l2_get_link_freq/20250119-224053
base: c4b7779abc6633677e6edb79e2809f4f61fde157
patch link: https://lore.kernel.org/r/20250119143904.114991-10-sakari.ailus%40linux.intel.com
patch subject: [PATCH v9 9/9] media: v4l: Convert the users of v4l2_get_link_freq to call it on a pad
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20250120/202501200228.jk1X695m-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250120/202501200228.jk1X695m-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501200228.jk1X695m-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/media/platform/qcom/camss/camss.c: In function 'camss_get_pixel_clock':
drivers/media/platform/qcom/camss/camss.c:2057:9: error: 'sensor_pad' undeclared (first use in this function); did you mean 'sensor'?
2057 | sensor_pad = camss_find_sensor_pad(entity);
| ^~~~~~~~~~
| sensor
drivers/media/platform/qcom/camss/camss.c:2057:9: note: each undeclared identifier is reported only once for each function it appears in
In file included from include/linux/container_of.h:5,
from include/linux/kernel.h:22,
from include/linux/clk.h:13,
from drivers/media/platform/qcom/camss/camss.c:10:
include/linux/container_of.h:20:35: error: invalid type argument of unary '*' (have 'int')
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/media/v4l2-subdev.h:1132:17: note: in expansion of macro 'container_of'
1132 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \
| ^~~~~~~~~~~~
drivers/media/platform/qcom/camss/camss.c:2061:18: note: in expansion of macro 'media_entity_to_v4l2_subdev'
2061 | subdev = media_entity_to_v4l2_subdev(sensor_pad->entity);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/container_of.h:21:35: error: invalid type argument of unary '*' (have 'int')
21 | __same_type(*(ptr), void), \
| ^~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:21:23: note: in expansion of macro '__same_type'
21 | __same_type(*(ptr), void), \
| ^~~~~~~~~~~
include/media/v4l2-subdev.h:1132:17: note: in expansion of macro 'container_of'
1132 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \
| ^~~~~~~~~~~~
drivers/media/platform/qcom/camss/camss.c:2061:18: note: in expansion of macro 'media_entity_to_v4l2_subdev'
2061 | subdev = media_entity_to_v4l2_subdev(sensor_pad->entity);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:483:27: error: expression in static assertion is not an integer
483 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/media/v4l2-subdev.h:1132:17: note: in expansion of macro 'container_of'
1132 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \
| ^~~~~~~~~~~~
drivers/media/platform/qcom/camss/camss.c:2061:18: note: in expansion of macro 'media_entity_to_v4l2_subdev'
2061 | subdev = media_entity_to_v4l2_subdev(sensor_pad->entity);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/qcom/camss/camss.c:2053:27: warning: unused variable 'sensor' [-Wunused-variable]
2053 | struct media_pad *sensor;
| ^~~~~~
vim +/sensor +2053 drivers/media/platform/qcom/camss/camss.c
2043
2044 /*
2045 * camss_get_pixel_clock - Get pixel clock rate from sensor
2046 * @entity: Media entity in the current pipeline
2047 * @pixel_clock: Received pixel clock value
2048 *
2049 * Return 0 on success or a negative error code otherwise
2050 */
2051 int camss_get_pixel_clock(struct media_entity *entity, u64 *pixel_clock)
2052 {
> 2053 struct media_pad *sensor;
2054 struct v4l2_subdev *subdev;
2055 struct v4l2_ctrl *ctrl;
2056
2057 sensor_pad = camss_find_sensor_pad(entity);
2058 if (!sensor_pad)
2059 return -ENODEV;
2060
2061 subdev = media_entity_to_v4l2_subdev(sensor_pad->entity);
2062
2063 ctrl = v4l2_ctrl_find(subdev->ctrl_handler, V4L2_CID_PIXEL_RATE);
2064
2065 if (!ctrl)
2066 return -EINVAL;
2067
2068 *pixel_clock = v4l2_ctrl_g_ctrl_int64(ctrl);
2069
2070 return 0;
2071 }
2072
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-01-19 18:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-19 14:38 [PATCH v9 0/9] Use V4L2 mbus config for conveying link frequency Sakari Ailus
2025-01-19 14:38 ` [PATCH v9 1/9] media: v4l: Support passing media pad argument to v4l2_get_link_freq() Sakari Ailus
2025-01-19 14:38 ` [PATCH v9 2/9] media: v4l: Support obtaining link frequency via get_mbus_config Sakari Ailus
2025-01-19 14:38 ` [PATCH v9 3/9] media: Documentation: Update link frequency driver documentation Sakari Ailus
2025-01-19 14:38 ` [PATCH v9 4/9] media: Documentation: tx-rx: Move transmitter control out of CSI-2 part Sakari Ailus
2025-01-19 14:39 ` [PATCH v9 5/9] media: Documentation: Receiver drivers should call v4l2_get_link_freq() Sakari Ailus
2025-01-19 14:39 ` [PATCH v9 6/9] media: v4l: Memset argument to 0 before calling get_mbus_config pad op Sakari Ailus
2025-01-19 14:39 ` [PATCH v9 7/9] media: intel/ipu6: Obtain link frequency from the remote subdev pad Sakari Ailus
2025-01-19 14:39 ` [PATCH v9 8/9] media: ivsc: csi: Obtain link frequency from the media pad Sakari Ailus
2025-01-19 14:39 ` [PATCH v9 9/9] media: v4l: Convert the users of v4l2_get_link_freq to call it on a pad Sakari Ailus
2025-01-19 17:46 ` kernel test robot
2025-01-19 18:17 ` kernel test robot [this message]
2025-01-19 18:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202501200228.jk1X695m-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=bingbu.cao@intel.com \
--cc=bparrot@ti.com \
--cc=bryan.odonoghue@linaro.org \
--cc=djrscally@gmail.com \
--cc=duclong.linux@gmail.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel-list@raspberrypi.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rfoss@kernel.org \
--cc=ribalda@chromium.org \
--cc=rmfrfs@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=sylvain.petinot@foss.st.com \
--cc=tian.shu.qiu@intel.com \
--cc=todor.too@gmail.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox