From: Mathis Foerst <mathis.foerst@mt.com>
To: linux-kernel@vger.kernel.org
Cc: Mathis Foerst <mathis.foerst@mt.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
manuel.traut@mt.com, mathis.foerst@zuehlke.com
Subject: [PATCH v2 7/7] media: mt9m114: Set pad-slew-rate
Date: Tue, 4 Mar 2025 11:36:47 +0100 [thread overview]
Message-ID: <20250304103647.34235-8-mathis.foerst@mt.com> (raw)
In-Reply-To: <20250304103647.34235-1-mathis.foerst@mt.com>
The MT9M114 supports the different slew rates (0 to 7) on the output pads.
At the moment, this is hardcoded to 7 (the fastest rate).
The user might want to change this values due to EMC requirements.
Read the 'pad-slew-rate' from the DT and configure the pad slew rates of
the output pads accordingly in mt9m114_initialize().
Remove the hardcoded slew rate setting from the mt9m114_init table.
Signed-off-by: Mathis Foerst <mathis.foerst@mt.com>
---
drivers/media/i2c/mt9m114.c | 23 ++++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c
index 9ab1147a9aaf..93e220854d20 100644
--- a/drivers/media/i2c/mt9m114.c
+++ b/drivers/media/i2c/mt9m114.c
@@ -42,6 +42,9 @@
#define MT9M114_RESET_AND_MISC_CONTROL CCI_REG16(0x001a)
#define MT9M114_RESET_SOC BIT(0)
#define MT9M114_PAD_SLEW CCI_REG16(0x001e)
+#define MT9M114_PAD_SLEW_MIN 0x00
+#define MT9M114_PAD_SLEW_MAX 0x07
+#define MT9M114_PAD_SLEW_DEFAULT 0x07
#define MT9M114_PAD_CONTROL CCI_REG16(0x0032)
/* XDMA registers */
@@ -388,6 +391,7 @@ struct mt9m114 {
unsigned int pixrate;
bool streaming;
+ u32 pad_slew_rate;
/* Pixel Array */
struct {
@@ -645,9 +649,6 @@ static const struct cci_reg_sequence mt9m114_init[] = {
{ MT9M114_CAM_SENSOR_CFG_FINE_INTEG_TIME_MAX, 1459 },
{ MT9M114_CAM_SENSOR_CFG_FINE_CORRECTION, 96 },
{ MT9M114_CAM_SENSOR_CFG_REG_0_DATA, 32 },
-
- /* Miscellaneous settings */
- { MT9M114_PAD_SLEW, 0x0777 },
};
/* -----------------------------------------------------------------------------
@@ -778,6 +779,13 @@ static int mt9m114_initialize(struct mt9m114 *sensor)
if (ret < 0)
return ret;
+ value = (sensor->pad_slew_rate & 0xF)
+ | (sensor->pad_slew_rate & 0xF) << 4
+ | (sensor->pad_slew_rate & 0xF) << 8;
+ cci_write(sensor->regmap, MT9M114_PAD_SLEW, value, &ret);
+ if (ret < 0)
+ return ret;
+
ret = mt9m114_set_state(sensor, MT9M114_SYS_STATE_ENTER_CONFIG_CHANGE);
if (ret < 0)
return ret;
@@ -2376,6 +2384,8 @@ static int mt9m114_parse_dt(struct mt9m114 *sensor)
{
struct fwnode_handle *fwnode = dev_fwnode(&sensor->client->dev);
struct fwnode_handle *ep;
+ struct device_node *dev_node = sensor->client->dev.of_node;
+ u32 slew_rate;
int ret;
ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
@@ -2404,6 +2414,13 @@ static int mt9m114_parse_dt(struct mt9m114 *sensor)
goto error;
}
+ sensor->bypass_pll = of_property_read_bool(dev_node, "bypass-pll");
+
+ ret = of_property_read_u32(dev_node, "pad-slew-rate", &slew_rate);
+ if (ret || slew_rate < MT9M114_PAD_SLEW_MIN || slew_rate > MT9M114_PAD_SLEW_MAX)
+ slew_rate = MT9M114_PAD_SLEW_DEFAULT;
+ sensor->pad_slew_rate = slew_rate;
+
return 0;
error:
--
2.34.1
prev parent reply other threads:[~2025-03-04 10:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 10:36 [PATCH v2 0/7] MT9M114 driver bugfix and improvements Mathis Foerst
2025-03-04 10:36 ` [PATCH v2 1/7] media: dt-bindings: mt9m114: Add pad-slew-rate DT-binding Mathis Foerst
2025-03-05 7:21 ` Krzysztof Kozlowski
2025-03-04 10:36 ` [PATCH v2 2/7] media: mt9m114: Add get_mbus_config Mathis Foerst
2025-03-04 10:36 ` [PATCH v2 3/7] media: mt9m114: Bypass PLL if required Mathis Foerst
2025-03-04 10:36 ` [PATCH v2 4/7] media: mt9m114: Factor out mt9m114_configure_pa Mathis Foerst
2025-03-04 10:36 ` [PATCH v2 5/7] media: mt9m114: Allow set_selection while streaming Mathis Foerst
2025-03-04 10:36 ` [PATCH v2 6/7] media: mt9m114: Fix deadlock in get_frame_interval/set_frame_interval Mathis Foerst
2025-03-04 10:36 ` Mathis Foerst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304103647.34235-8-mathis.foerst@mt.com \
--to=mathis.foerst@mt.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manuel.traut@mt.com \
--cc=mathis.foerst@zuehlke.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox