public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Leitner <richard.leitner@linux.dev>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Dave Stevenson <dave.stevenson@raspberrypi.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	Lee Jones <lee@kernel.org>,  Pavel Machek <pavel@kernel.org>,
	 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	linux-media@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org,
	 Richard Leitner <richard.leitner@linux.dev>
Subject: [PATCH v5 08/10] media: i2c: ov9282: add strobe_source v4l2 control
Date: Tue, 17 Jun 2025 09:31:42 +0200	[thread overview]
Message-ID: <20250617-ov9282-flash-strobe-v5-8-9762da74d065@linux.dev> (raw)
In-Reply-To: <20250617-ov9282-flash-strobe-v5-0-9762da74d065@linux.dev>

Add read-only V4L2_CID_FLASH_STROBE_SOURCE control. Its value is fixed
to V4L2_FLASH_STROBE_SOURCE_EXTERNAL as the camera sensor triggers the
strobe based on its register settings.

Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
---
 drivers/media/i2c/ov9282.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
index 871cd7e796531c1f958790eba733290d39e99f0c..2d77b9108bcd2499a40418919e260e7d53a9a64e 100644
--- a/drivers/media/i2c/ov9282.c
+++ b/drivers/media/i2c/ov9282.c
@@ -1368,11 +1368,12 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
 	struct v4l2_ctrl_handler *ctrl_hdlr = &ov9282->ctrl_handler;
 	const struct ov9282_mode *mode = ov9282->cur_mode;
 	struct v4l2_fwnode_device_properties props;
+	struct v4l2_ctrl *ctrl;
 	u32 hblank_min;
 	u32 lpfr;
 	int ret;
 
-	ret = v4l2_ctrl_handler_init(ctrl_hdlr, 12);
+	ret = v4l2_ctrl_handler_init(ctrl_hdlr, 13);
 	if (ret)
 		return ret;
 
@@ -1447,6 +1448,14 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
 	v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, V4L2_CID_FLASH_DURATION,
 			  0, 13900, 1, 8);
 
+	ctrl = v4l2_ctrl_new_std_menu(ctrl_hdlr, &ov9282_ctrl_ops,
+				      V4L2_CID_FLASH_STROBE_SOURCE,
+				      V4L2_FLASH_STROBE_SOURCE_EXTERNAL,
+				      ~(1 << V4L2_FLASH_STROBE_SOURCE_EXTERNAL),
+				      V4L2_FLASH_STROBE_SOURCE_EXTERNAL);
+	if (ctrl)
+		ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
 	ret = v4l2_fwnode_device_parse(ov9282->dev, &props);
 	if (!ret) {
 		/* Failure sets ctrl_hdlr->error, which we check afterwards anyway */

-- 
2.47.2



  parent reply	other threads:[~2025-06-17  7:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17  7:31 [PATCH v5 00/10] Add strobe/flash duration v4l2 ctrl & use it for ov9282 Richard Leitner
2025-06-17  7:31 ` [PATCH v5 01/10] media: v4l: ctrls: add a control for flash/strobe duration Richard Leitner
2025-06-17  7:31 ` [PATCH v5 02/10] media: v4l2-flash: add support " Richard Leitner
2025-06-17  7:31 ` [PATCH v5 03/10] media: v4l2-flash: fix flash_timeout comment Richard Leitner
2025-06-19  9:37   ` (subset) " Lee Jones
2025-06-19  9:38     ` Lee Jones
2025-07-01  6:36       ` Richard Leitner
2025-06-17  7:31 ` [PATCH v5 04/10] Documentation: uAPI: media: add V4L2_CID_FLASH_DURATION Richard Leitner
2025-06-17  7:31 ` [PATCH v5 05/10] media: i2c: ov9282: add output enable register definitions Richard Leitner
2025-06-17  7:31 ` [PATCH v5 06/10] media: i2c: ov9282: add led_mode v4l2 control Richard Leitner
2025-07-09 21:12   ` Sakari Ailus
2025-07-10  6:50     ` Richard Leitner
2025-07-10  8:14       ` Sakari Ailus
2025-07-11  7:41         ` Richard Leitner
2025-07-30 20:39           ` Sakari Ailus
2025-08-04 13:33             ` Richard Leitner
2025-06-17  7:31 ` [PATCH v5 07/10] media: i2c: ov9282: add strobe_duration " Richard Leitner
2025-06-17  7:31 ` Richard Leitner [this message]
2025-06-17  7:31 ` [PATCH v5 09/10] media: i2c: ov9282: implement try_ctrl for strobe_duration Richard Leitner
2025-06-18 13:04   ` kernel test robot
2025-06-17  7:31 ` [PATCH v5 10/10] media: i2c: ov9282: dynamic flash_duration maximum Richard Leitner
2025-07-09  5:24 ` [PATCH v5 00/10] Add strobe/flash duration v4l2 ctrl & use it for ov9282 Richard Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250617-ov9282-flash-strobe-v5-8-9762da74d065@linux.dev \
    --to=richard.leitner@linux.dev \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pavel@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox