Re: [PATCH v5 06/10] media: i2c: ov9282: add led_mode v4l2 control

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Richard,

On Thu, Jul 10, 2025 at 08:50:24AM +0200, Richard Leitner wrote:
> Hi Sakari,
> 
> thanks for the feedback :)
> 
> On Wed, Jul 09, 2025 at 09:12:57PM +0000, Sakari Ailus wrote:
> > Hi Richard,
> > 
> > Thanks for the update.
> > 
> > On Tue, Jun 17, 2025 at 09:31:40AM +0200, Richard Leitner wrote:
> > > Add V4L2_CID_FLASH_LED_MODE support using the "strobe output enable"
> > > feature of the sensor. This implements following modes:
> > > 
> > >  - V4L2_FLASH_LED_MODE_NONE, which disables the strobe output
> > >  - V4L2_FLASH_LED_MODE_FLASH, which enables the strobe output
> > 
> > I really think you should use a different control for this. The sensor can
> > strobe the flash but it won't control its mode.
> > 
> > How about calling it V4L2_FLASH_STROBE_ENABLE?
> 
> I agree on that. But tbh V4L2_FLASH_STROBE_ENABLE somehow sounds wrong
> to me. As the strobe output in the ov9282 case goes high for the strobe
> duration, what do you think about calling it V4L2_FLASH_STROBE_PULSE?

That's how the hardware strobe is supposed to work, there's nothing unusual
in that. How about V4L2_FLASH_HW_STROBE_ENABLE?

> Or should it be V4L2_FLASH_LED_MODE_STROBE_PULSE?
> 
> Regarding disabling the strobe output: Is sticking with V4L2_FLASH_LED_MODE_NONE
> fine? Or do you prefer an additional V4L2_FLASH_(MODE_)STROBE_DISABLE
> or something similar?

This isn't about the LED flash mode and we shouldn't suggest it is.

-- 
Regards,

Sakari Ailus