Re: [PATCH 0/2] media: uvcvideo: Enable keep-sorted

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Tue, Jun 17, 2025 at 01:52:50PM +0200, Hans Verkuil wrote:
> On 16/06/2025 15:38, Hans de Goede wrote:
> > On 16-Jun-25 15:31, Ricardo Ribalda wrote:
> >> On Mon, 16 Jun 2025 at 15:26, Hans de Goede <hansg@kernel.org> wrote:
> >>> On 16-Jun-25 15:22, Ricardo Ribalda wrote:
> >>>> On Mon, 16 Jun 2025 at 15:05, Hans de Goede <hansg@kernel.org> wrote:
> >>>>> On 29-Apr-25 15:47, Ricardo Ribalda wrote:
> >>>>>> When committers contribute quirks to the uvc driver, they usually add
> >>>>>> them out of order.
> >>>>>>
> >>>>>> We can automatically validate that their follow our guidelines with the
> >>>>>> use of keep-sorted.
> >>>>>>
> >>>>>> This patchset adds support for keep-sorted in the uvc driver. The two
> >>>>>> patches can be squashed if needed.
> >>>>>>
> >>>>>> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> >>>>>
> >>>>> I've no objections against these 2 patches, but these need to be
> >>>>> rebased on top of the latest uvc/for-next. Can you send out a new
> >>>>> version please ?
> >>>>
> >>>> I was waiting for HansV to say that keep-sorted was useful and then
> >>>> add it to the CI.
> >>>
> >>> Ok, so should we drop this series from patchwork then ?
> >>
> >> If the series does not bother you too much in patchwork let it stay
> >> there until HansV replies to the makefile series.
> 
> I did that. Basically I don't like the keep-sorted annotation unless it
> is rolled out kernel-wide. It's not something we should do just in the
> media subsystem.
> 
> That doesn't mean that a patch fixing the uvc_ids order isn't welcome,
> but just drop the annotation.
> 
> If we do that, then patch 1/2 is also no longer needed. Although it
> feels more logical that match_flags is at the end. I leave that to
> HdG and Laurent to decide.

.match_flags is first to match the order of the fields in the
usb_device_id structure. Is there a need to move it last, or is only the

	}, {

construct that the tool doesn't like ?

> > Sure that works for me.

-- 
Regards,

Laurent Pinchart