Re: [PATCH 0/2] media: uvcvideo: Enable keep-sorted

[Hans de Goede <hansg@kernel.org>]

Hi Ricardo,

On 16-Jun-25 15:22, Ricardo Ribalda wrote:
> Hi Hans
> 
> On Mon, 16 Jun 2025 at 15:05, Hans de Goede <hansg@kernel.org> wrote:
>>
>> Hi Ricardo,
>>
>> On 29-Apr-25 15:47, Ricardo Ribalda wrote:
>>> When committers contribute quirks to the uvc driver, they usually add
>>> them out of order.
>>>
>>> We can automatically validate that their follow our guidelines with the
>>> use of keep-sorted.
>>>
>>> This patchset adds support for keep-sorted in the uvc driver. The two
>>> patches can be squashed if needed.
>>>
>>> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>>
>> I've no objections against these 2 patches, but these need to be
>> rebased on top of the latest uvc/for-next. Can you send out a new
>> version please ?
> 
> I was waiting for HansV to say that keep-sorted was useful and then
> add it to the CI.

Ok, so should we drop this series from patchwork then ?

> 
> Right now it is probably just useful for the Makefiles and uvc.
> 
>>
>> Also for patch 2/2 can we not just add the 2 keep-sorted headers
>> and then actually run keep-sorted to auto-fix things ?
> 
> Do you mean removing the annotation after running keep-sorted?
> 
> We can do that, but we will be unsorted again in the future after N
> patches unless we add it to CI.
> 
> If we do not handle this automatically I do not think that there is
> much point on this series.

What I meant is only add the annotations and then run something
like:

keepsorted --auto-fix drivers/media/usb/uvc/uvc_driver.c

and submit the result as a separate commit. Assuming that there is such
a thing as --auto-fix. The reason for this is that if the sorting is done
by a tool there is last chance for it to accidentally break things.

Regards,

Hans