[PATCH] media: chips-media: wave5: fix a potential memory leak in wave5_vdi_init()

[PATCH] media: chips-media: wave5: fix a potential memory leak in wave5_vdi_init()

[Haoxiang Li]

Add wave5_vdi_free_dma_memory() in the error path of
wave5_vdi_init() to prevent a potential memory leak.

Fixes: 45d1a2b93277 ("media: chips-media: wave5: Add vpuapi layer")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
 drivers/media/platform/chips-media/wave5/wave5-vdi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/chips-media/wave5/wave5-vdi.c b/drivers/media/platform/chips-media/wave5/wave5-vdi.c
index bb13267ced38..8f71920a8a35 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-vdi.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-vdi.c
@@ -49,6 +49,7 @@ int wave5_vdi_init(struct device *dev)
 
 	if (!PRODUCT_CODE_W_SERIES(vpu_dev->product_code)) {
 		WARN_ONCE(1, "unsupported product code: 0x%x\n", vpu_dev->product_code);
+		wave5_vdi_free_dma_memory(vpu_dev, &vpu_dev->common_mem);
 		return -EOPNOTSUPP;
 	}
 
-- 
2.25.1

Re: [PATCH] media: chips-media: wave5: fix a potential memory leak in wave5_vdi_init()

[Greg KH]

On Sun, Jan 25, 2026 at 10:19:15PM +0800, Haoxiang Li wrote:
> Add wave5_vdi_free_dma_memory() in the error path of
> wave5_vdi_init() to prevent a potential memory leak.
> 
> Fixes: 45d1a2b93277 ("media: chips-media: wave5: Add vpuapi layer")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
> ---
>  drivers/media/platform/chips-media/wave5/wave5-vdi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vdi.c b/drivers/media/platform/chips-media/wave5/wave5-vdi.c
> index bb13267ced38..8f71920a8a35 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vdi.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vdi.c
> @@ -49,6 +49,7 @@ int wave5_vdi_init(struct device *dev)
>  
>  	if (!PRODUCT_CODE_W_SERIES(vpu_dev->product_code)) {
>  		WARN_ONCE(1, "unsupported product code: 0x%x\n", vpu_dev->product_code);
> +		wave5_vdi_free_dma_memory(vpu_dev, &vpu_dev->common_mem);
>  		return -EOPNOTSUPP;
>  	}
>  
> -- 
> 2.25.1
> 
> 

How was this found and tested?

thanks,

greg k-h

Re: [PATCH] media: chips-media: wave5: fix a potential memory leak in wave5_vdi_init()

[Nicolas Dufresne]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

Hi,

Le dimanche 25 janvier 2026 à 22:19 +0800, Haoxiang Li a écrit :
> Add wave5_vdi_free_dma_memory() in the error path of
> wave5_vdi_init() to prevent a potential memory leak.
> 
> Fixes: 45d1a2b93277 ("media: chips-media: wave5: Add vpuapi layer")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>

It would have been nice to reply to Greg, that being said, I carefully reviewed
and this effectively fix a leak in an error path. Description is brief but
sufficient in my opinion.

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/media/platform/chips-media/wave5/wave5-vdi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vdi.c b/drivers/media/platform/chips-media/wave5/wave5-vdi.c
> index bb13267ced38..8f71920a8a35 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vdi.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vdi.c
> @@ -49,6 +49,7 @@ int wave5_vdi_init(struct device *dev)
>  
>  	if (!PRODUCT_CODE_W_SERIES(vpu_dev->product_code)) {
>  		WARN_ONCE(1, "unsupported product code: 0x%x\n", vpu_dev->product_code);
> +		wave5_vdi_free_dma_memory(vpu_dev, &vpu_dev->common_mem);
>  		return -EOPNOTSUPP;
>  	}
>  

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]