public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Shiyan <eagle.alexander923@gmail.com>
To: linux-media@vger.kernel.org
Cc: Michael Riesch <michael.riesch@collabora.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Gerald Loacker <gerald.loacker@wolfvision.net>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Alexander Shiyan <eagle.alexander923@gmail.com>,
	Michael Riesch <michael.riesch@wolfvision.net>
Subject: [PATCH v2 1/5] media: i2c: imx415: Add missing ADBIT1 register for 10/12-bit output
Date: Fri, 10 Apr 2026 09:19:40 +0300	[thread overview]
Message-ID: <20260410061944.241480-2-eagle.alexander923@gmail.com> (raw)
In-Reply-To: <20260410061944.241480-1-eagle.alexander923@gmail.com>

Add the missing ADBIT1 register definition (0x3701) and initialise it
to 0 in the init sequence.
Set both ADBIT (0x3031) and ADBIT1 to the same value to comply with
the datasheet (Operating mode table, page 48): 0 for 10-bit mode,
1 for 12-bit mode.

Fixes: 14cd15e7a1e2 ("media: i2c: add imx415 cmos image sensor driver")
Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>
Reviewed-by: Gerald Loacker <gerald.loacker@wolfvision.net>
Tested-by: Gerald Loacker <gerald.loacker@wolfvision.net>
Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
 drivers/media/i2c/imx415.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
index 0b424c17e880..507a8c557ff1 100644
--- a/drivers/media/i2c/imx415.c
+++ b/drivers/media/i2c/imx415.c
@@ -77,6 +77,7 @@
 #define IMX415_INCKSEL5		  CCI_REG8(0x311e)
 #define IMX415_DIG_CLP_MODE	  CCI_REG8(0x32c8)
 #define IMX415_WRJ_OPEN		  CCI_REG8(0x3390)
+#define IMX415_ADBIT1		  CCI_REG8(0x3701)
 #define IMX415_SENSOR_INFO	  CCI_REG16_LE(0x3f12)
 #define IMX415_SENSOR_INFO_MASK	  0xfff
 #define IMX415_CHIP_ID		  0x514
@@ -581,6 +582,7 @@ static const struct cci_reg_sequence imx415_init_table[] = {
 	{ IMX415_REVERSE, 0x00 },
 	/* use RAW 10-bit mode */
 	{ IMX415_ADBIT, 0x00 },
+	{ IMX415_ADBIT1, 0x00 },
 	{ IMX415_MDBIT, 0x00 },
 	/* output VSYNC on XVS and low on XHS */
 	{ IMX415_OUTSEL, 0x22 },
-- 
2.52.0


  reply	other threads:[~2026-04-10  6:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10  6:19 [PATCH v2 0/5] media: i2c: imx415: driver improvements and fixes Alexander Shiyan
2026-04-10  6:19 ` Alexander Shiyan [this message]
2026-04-10  6:19 ` [PATCH v2 2/5] media: i2c: imx415: Add missing CSI-2 timing configurations for all lane rates Alexander Shiyan
2026-04-10  6:19 ` [PATCH v2 3/5] media: i2c: imx415: Add missing 4-lane CSI-2 timing configurations Alexander Shiyan
2026-04-10  6:19 ` [PATCH v2 4/5] media: i2c: imx415: Fix control handler initial count Alexander Shiyan
2026-04-10  6:19 ` [PATCH v2 5/5] media: i2c: imx415: Cluster horizontal and vertical flip controls Alexander Shiyan
2026-04-17 12:23 ` [PATCH v2 0/5] media: i2c: imx415: driver improvements and fixes Michael Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260410061944.241480-2-eagle.alexander923@gmail.com \
    --to=eagle.alexander923@gmail.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=gerald.loacker@wolfvision.net \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=michael.riesch@collabora.com \
    --cc=michael.riesch@wolfvision.net \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox