[PATCH v2 0/2] media: renesas: vsp1: Fix display pipeline regression

[PATCH v2 0/2] media: renesas: vsp1: Fix display pipeline regression

[Laurent Pinchart]

Hello,

Two commits merged in v7.1-rc1 introduced a regression in the display
pipeline. This series revert them to fix the regression.

The commits were meant to fix v4l2-compliance failures. Those failures
have never caused any issue in production use cases, and have never been
reported as issue by anyone. Reverting the commits is therefore the
safer option, to give us more time to address the v4l2-compliance
failures in a better way.

Laurent Pinchart (2):
  Revert "media: renesas: vsp1: Initialize format on all pads"
  Revert "media: renesas: vsp1: brx: Fix format propagation"

 drivers/media/platform/renesas/vsp1/vsp1_brx.c    | 10 ++--------
 drivers/media/platform/renesas/vsp1/vsp1_entity.c |  2 +-
 2 files changed, 3 insertions(+), 9 deletions(-)


base-commit: 3cd9b7011519c3fffffb7b6752fc7603be52dc1d
-- 
Regards,

Laurent Pinchart

[PATCH v2 1/2] Revert "media: renesas: vsp1: Initialize format on all pads"

[Laurent Pinchart]

This reverts commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6.

The change to format initialization, along with the change to format
propagation in the BRx in commit 937f3e6b51f1 ("media: renesas: vsp1:
brx: Fix format propagation"), broke configuration of the DRM pipeline.
Revert it to fix the regression.

The original commit was meant to fix a v4l2-compliance failure, with no
known userspace applications being affected beside test tools. Reverting
is the simplest option, a more comprehensive fix can be developed (and
tested more thoroughly) later.

Fixes: 133ac42af0a1 ("media: renesas: vsp1: Initialize format on all pads")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/media/platform/renesas/vsp1/vsp1_entity.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.c b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
index 1dad9589768c..839b75b62ceb 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_entity.c
+++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
@@ -380,7 +380,7 @@ static int vsp1_entity_init_state(struct v4l2_subdev *subdev,
 	unsigned int pad;
 
 	/* Initialize all pad formats with default values. */
-	for (pad = 0; pad < subdev->entity.num_pads; ++pad) {
+	for (pad = 0; pad < subdev->entity.num_pads - 1; ++pad) {
 		struct v4l2_subdev_format format = {
 			.pad = pad,
 			.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY
-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 1/2] Revert "media: renesas: vsp1: Initialize format on all pads"

[Lad, Prabhakar]

On Wed, May 6, 2026 at 11:00 PM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
>
> This reverts commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6.
>
> The change to format initialization, along with the change to format
> propagation in the BRx in commit 937f3e6b51f1 ("media: renesas: vsp1:
> brx: Fix format propagation"), broke configuration of the DRM pipeline.
> Revert it to fix the regression.
>
> The original commit was meant to fix a v4l2-compliance failure, with no
> known userspace applications being affected beside test tools. Reverting
> is the simplest option, a more comprehensive fix can be developed (and
> tested more thoroughly) later.
>
> Fixes: 133ac42af0a1 ("media: renesas: vsp1: Initialize format on all pads")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/media/platform/renesas/vsp1/vsp1_entity.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> # On RZ/T2H
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar


> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.c b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
> index 1dad9589768c..839b75b62ceb 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_entity.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
> @@ -380,7 +380,7 @@ static int vsp1_entity_init_state(struct v4l2_subdev *subdev,
>         unsigned int pad;
>
>         /* Initialize all pad formats with default values. */
> -       for (pad = 0; pad < subdev->entity.num_pads; ++pad) {
> +       for (pad = 0; pad < subdev->entity.num_pads - 1; ++pad) {
>                 struct v4l2_subdev_format format = {
>                         .pad = pad,
>                         .which = sd_state ? V4L2_SUBDEV_FORMAT_TRY
> --
> Regards,
>
> Laurent Pinchart
>
>

[PATCH v2 2/2] Revert "media: renesas: vsp1: brx: Fix format propagation"

[Laurent Pinchart]

This reverts commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f.

The change to format propagation in the BRx broke configuration of the
DRM pipeline. Revert it to fix the regression.

The original commit was meant to fix a v4l2-compliance failure, with no
known userspace applications being affected beside test tools. Reverting
is the simplest option, a more comprehensive fix can be developed (and
tested more thoroughly) later.

Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Closes: https://lore.kernel.org/linux-media/CA+V-a8t481xuwava0nb7uY9CUPqFWZ_8EP0xrK3BgumP7HDcLg@mail.gmail.com
Fixes: 937f3e6b51f1 ("media: renesas: vsp1: brx: Fix format propagation")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/media/platform/renesas/vsp1/vsp1_brx.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/media/platform/renesas/vsp1/vsp1_brx.c b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
index b1a2c68e9944..9d93cb8b8e82 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_brx.c
+++ b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
@@ -156,20 +156,14 @@ static int brx_set_format(struct v4l2_subdev *subdev,
 		compose->height = format->height;
 	}
 
-	/*
-	 * Propagate the format code to all pads, and the whole format to the
-	 * source pad.
-	 */
+	/* Propagate the format code to all pads. */
 	if (fmt->pad == BRX_PAD_SINK(0)) {
 		unsigned int i;
 
-		for (i = 0; i < brx->entity.source_pad; ++i) {
+		for (i = 0; i <= brx->entity.source_pad; ++i) {
 			format = v4l2_subdev_state_get_format(state, i);
 			format->code = fmt->format.code;
 		}
-
-		format = v4l2_subdev_state_get_format(state, i);
-		*format = fmt->format;
 	}
 
 done:
-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 2/2] Revert "media: renesas: vsp1: brx: Fix format propagation"

[Lad, Prabhakar]

On Wed, May 6, 2026 at 10:57 PM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
>
> This reverts commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f.
>
> The change to format propagation in the BRx broke configuration of the
> DRM pipeline. Revert it to fix the regression.
>
> The original commit was meant to fix a v4l2-compliance failure, with no
> known userspace applications being affected beside test tools. Reverting
> is the simplest option, a more comprehensive fix can be developed (and
> tested more thoroughly) later.
>
> Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Closes: https://lore.kernel.org/linux-media/CA+V-a8t481xuwava0nb7uY9CUPqFWZ_8EP0xrK3BgumP7HDcLg@mail.gmail.com
> Fixes: 937f3e6b51f1 ("media: renesas: vsp1: brx: Fix format propagation")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/media/platform/renesas/vsp1/vsp1_brx.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> # On RZ/T2H
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_brx.c b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> index b1a2c68e9944..9d93cb8b8e82 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> @@ -156,20 +156,14 @@ static int brx_set_format(struct v4l2_subdev *subdev,
>                 compose->height = format->height;
>         }
>
> -       /*
> -        * Propagate the format code to all pads, and the whole format to the
> -        * source pad.
> -        */
> +       /* Propagate the format code to all pads. */
>         if (fmt->pad == BRX_PAD_SINK(0)) {
>                 unsigned int i;
>
> -               for (i = 0; i < brx->entity.source_pad; ++i) {
> +               for (i = 0; i <= brx->entity.source_pad; ++i) {
>                         format = v4l2_subdev_state_get_format(state, i);
>                         format->code = fmt->format.code;
>                 }
> -
> -               format = v4l2_subdev_state_get_format(state, i);
> -               *format = fmt->format;
>         }
>
>  done:
> --
> Regards,
>
> Laurent Pinchart
>
>

Re: [v2,0/2] media: renesas: vsp1: Fix display pipeline regression

[Laurent Pinchart]

On Wed, May 06, 2026 at 03:59:20PM -0700, Patchwork Integration wrote:
> Dear Laurent Pinchart:
> 
> Thanks for your patches! Unfortunately the Media CI robot detected some
> issues:
> 
> # Test media-patchstyle:./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch media style
> ERROR: ./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by
> ERROR: Commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6 found in the stable tree, but stable@vger.kernel.org not in Cc:
> 
> # Test media-patchstyle:./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch media style
> ERROR: ./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by

I'm not going to add your SoB to my patches :-)

> ERROR: Commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f found in the stable tree, but stable@vger.kernel.org not in Cc:

I don't see these commits in any of the stable branches. Does the
message mean the mainline tree, not the stable tree ?

Given that this series should be merged in v7.1 as a regression fix, why
should it CC stable ?

> Please fix your series, and upload a new version. If you have a patchwork
> account, do not forget to mark the current series as Superseded.
> 
> For more details, check the full report at:
> https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/99198847/artifacts/report.htm .
> 
> 
> 
> Best regards, and Happy Hacking!
> Media CI robot on behalf of the linux-media community.
> 
> ---
> Check the latest rules for contributing your patches at:
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> 
> If you believe that the CI is wrong, kindly open an issue at
> https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> to this message.

-- 
Regards,

Laurent Pinchart

Re: [v2,0/2] media: renesas: vsp1: Fix display pipeline regression

[Ricardo Ribalda]

Hi Laurent

On Thu, 7 May 2026 at 01:11, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> On Wed, May 06, 2026 at 03:59:20PM -0700, Patchwork Integration wrote:
> > Dear Laurent Pinchart:
> >
> > Thanks for your patches! Unfortunately the Media CI robot detected some
> > issues:
> >
> > # Test media-patchstyle:./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch media style
> > ERROR: ./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by
> > ERROR: Commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6 found in the stable tree, but stable@vger.kernel.org not in Cc:
> >
> > # Test media-patchstyle:./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch media style
> > ERROR: ./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by
>
> I'm not going to add your SoB to my patches :-)

You did not get the memo. From now on, all patches in the kernel need
to be SoB my me :P

Sorry about that, Yesterday I had to recreate the local repo and
forgot to set the proper committer. It should be fixed now.

>
> > ERROR: Commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f found in the stable tree, but stable@vger.kernel.org not in Cc:
>
> I don't see these commits in any of the stable branches. Does the
> message mean the mainline tree, not the stable tree ?

It means the stable tree

ribalda@ribalda:~/work/linux$ git fetch
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
937f3e6b51f1cea079be9ba642665f2bf8bcc31f
From git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux
 * branch
937f3e6b51f1cea079be9ba642665f2bf8bcc31f -> FETCH_HEAD


>
> Given that this series should be merged in v7.1 as a regression fix, why
> should it CC stable ?

Somehow that patch has been backported, so I guess it should cc stable.

>
> > Please fix your series, and upload a new version. If you have a patchwork
> > account, do not forget to mark the current series as Superseded.
> >
> > For more details, check the full report at:
> > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/99198847/artifacts/report.htm .
> >
> >
> >
> > Best regards, and Happy Hacking!
> > Media CI robot on behalf of the linux-media community.
> >
> > ---
> > Check the latest rules for contributing your patches at:
> > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> >
> > If you believe that the CI is wrong, kindly open an issue at
> > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> > to this message.
>
> --
> Regards,
>
> Laurent Pinchart



-- 
Ricardo Ribalda

Re: [v2,0/2] media: renesas: vsp1: Fix display pipeline regression

[Laurent Pinchart]

On Thu, May 07, 2026 at 07:30:43AM +0200, Ricardo Ribalda wrote:
> On Thu, 7 May 2026 at 01:11, Laurent Pinchart wrote:
> > On Wed, May 06, 2026 at 03:59:20PM -0700, Patchwork Integration wrote:
> > > Dear Laurent Pinchart:
> > >
> > > Thanks for your patches! Unfortunately the Media CI robot detected some
> > > issues:
> > >
> > > # Test media-patchstyle:./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch media style
> > > ERROR: ./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by
> > > ERROR: Commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6 found in the stable tree, but stable@vger.kernel.org not in Cc:
> > >
> > > # Test media-patchstyle:./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch media style
> > > ERROR: ./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by
> >
> > I'm not going to add your SoB to my patches :-)
> 
> You did not get the memo. From now on, all patches in the kernel need
> to be SoB my me :P
> 
> Sorry about that, Yesterday I had to recreate the local repo and
> forgot to set the proper committer. It should be fixed now.
> 
> > > ERROR: Commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f found in the stable tree, but stable@vger.kernel.org not in Cc:
> >
> > I don't see these commits in any of the stable branches. Does the
> > message mean the mainline tree, not the stable tree ?
> 
> It means the stable tree
> 
> ribalda@ribalda:~/work/linux$ git fetch
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
> 937f3e6b51f1cea079be9ba642665f2bf8bcc31f
> From git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux
>  * branch
> 937f3e6b51f1cea079be9ba642665f2bf8bcc31f -> FETCH_HEAD

Ah right. But I don't think that's relevant. The commit is from the
master branch of the stable tree, which simply mirrors Linus' tree. It's
not in any stable branch.

$ git clone https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git stable
Cloning into 'stable'...
[...]
laurent@killaraus ~/src/kernel $ cd stable
laurent@killaraus ~/src/kernel/stable $ git branch -a --contains 937f3e6b51f1cea079be9ba642665f2bf8bcc31f
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
laurent@killaraus ~/src/kernel/stable $ git tag --contains 937f3e6b51f1cea079be9ba642665f2bf8bcc31f
v7.1-rc1
v7.1-rc2

This means the commit hasn't been backported to stable, it has just been
merged to mainline.

If the purpose of this is to check if the commit has been merged in
mainline, I think the message should refer to mainline. If it's to check
if it has been backported to a stable kernel, then those are false
positives.

Note that commit ID change when they're backported. If you want to check
if a commit has been backported, you'll need to grep for

    commit ${upstream_commit_id} upstream.

in commit *messages* of all stable branches.

> > Given that this series should be merged in v7.1 as a regression fix, why
> > should it CC stable ?
> 
> Somehow that patch has been backported, so I guess it should cc stable.

No, it hasn't been backported.

> > > Please fix your series, and upload a new version. If you have a patchwork
> > > account, do not forget to mark the current series as Superseded.
> > >
> > > For more details, check the full report at:
> > > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/99198847/artifacts/report.htm .
> > >
> > >
> > >
> > > Best regards, and Happy Hacking!
> > > Media CI robot on behalf of the linux-media community.
> > >
> > > ---
> > > Check the latest rules for contributing your patches at:
> > > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> > >
> > > If you believe that the CI is wrong, kindly open an issue at
> > > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> > > to this message.

-- 
Regards,

Laurent Pinchart

Re: [v2,0/2] media: renesas: vsp1: Fix display pipeline regression

[Ricardo Ribalda]

Hi Laurent



On Thu, 7 May 2026 at 10:18, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> On Thu, May 07, 2026 at 07:30:43AM +0200, Ricardo Ribalda wrote:
> > On Thu, 7 May 2026 at 01:11, Laurent Pinchart wrote:
> > > On Wed, May 06, 2026 at 03:59:20PM -0700, Patchwork Integration wrote:
> > > > Dear Laurent Pinchart:
> > > >
> > > > Thanks for your patches! Unfortunately the Media CI robot detected some
> > > > issues:
> > > >
> > > > # Test media-patchstyle:./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch media style
> > > > ERROR: ./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by
> > > > ERROR: Commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6 found in the stable tree, but stable@vger.kernel.org not in Cc:
> > > >
> > > > # Test media-patchstyle:./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch media style
> > > > ERROR: ./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by
> > >
> > > I'm not going to add your SoB to my patches :-)
> >
> > You did not get the memo. From now on, all patches in the kernel need
> > to be SoB my me :P
> >
> > Sorry about that, Yesterday I had to recreate the local repo and
> > forgot to set the proper committer. It should be fixed now.
> >
> > > > ERROR: Commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f found in the stable tree, but stable@vger.kernel.org not in Cc:
> > >
> > > I don't see these commits in any of the stable branches. Does the
> > > message mean the mainline tree, not the stable tree ?
> >
> > It means the stable tree
> >
> > ribalda@ribalda:~/work/linux$ git fetch
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
> > 937f3e6b51f1cea079be9ba642665f2bf8bcc31f
> > From git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux
> >  * branch
> > 937f3e6b51f1cea079be9ba642665f2bf8bcc31f -> FETCH_HEAD
>
> Ah right. But I don't think that's relevant. The commit is from the
> master branch of the stable tree, which simply mirrors Linus' tree. It's
> not in any stable branch.
>
> $ git clone https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git stable
> Cloning into 'stable'...
> [...]
> laurent@killaraus ~/src/kernel $ cd stable
> laurent@killaraus ~/src/kernel/stable $ git branch -a --contains 937f3e6b51f1cea079be9ba642665f2bf8bcc31f
> * master
>   remotes/origin/HEAD -> origin/master
>   remotes/origin/master
> laurent@killaraus ~/src/kernel/stable $ git tag --contains 937f3e6b51f1cea079be9ba642665f2bf8bcc31f
> v7.1-rc1
> v7.1-rc2
>
> This means the commit hasn't been backported to stable, it has just been
> merged to mainline.
>
> If the purpose of this is to check if the commit has been merged in
> mainline, I think the message should refer to mainline. If it's to check
> if it has been backported to a stable kernel, then those are false
> positives.
>
> Note that commit ID change when they're backported. If you want to check
> if a commit has been backported, you'll need to grep for
>
>     commit ${upstream_commit_id} upstream.
>
> in commit *messages* of all stable branches.
>
> > > Given that this series should be merged in v7.1 as a regression fix, why
> > > should it CC stable ?
> >
> > Somehow that patch has been backported, so I guess it should cc stable.
>
> No, it hasn't been backported.
>

You are completely right. And we have been doing this wrong for a long time....

We have a challenge that it is not trivial to fix. The builder do not
have a clone of linus-stable, it queries it with something similar to
"git ls-remote". So I cannot use "git log | grep".

Ideally we could have a web server to check if a sha has been
backported, but that does not exist yet. It could probably be a nice
little vibecoding project.

The question right now is if it is best to disable the check
completely or keep it and live with the false positives.

Need to check with my pillow.

> > > > Please fix your series, and upload a new version. If you have a patchwork
> > > > account, do not forget to mark the current series as Superseded.
> > > >
> > > > For more details, check the full report at:
> > > > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/99198847/artifacts/report.htm .
> > > >
> > > >
> > > >
> > > > Best regards, and Happy Hacking!
> > > > Media CI robot on behalf of the linux-media community.
> > > >
> > > > ---
> > > > Check the latest rules for contributing your patches at:
> > > > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> > > >
> > > > If you believe that the CI is wrong, kindly open an issue at
> > > > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> > > > to this message.
>
> --
> Regards,
>
> Laurent Pinchart



-- 
Ricardo Ribalda

Re: [v2,0/2] media: renesas: vsp1: Fix display pipeline regression

[Laurent Pinchart]

On Thu, May 07, 2026 at 10:38:33AM +0200, Ricardo Ribalda wrote:
> On Thu, 7 May 2026 at 10:18, Laurent Pinchart wrote:
> > On Thu, May 07, 2026 at 07:30:43AM +0200, Ricardo Ribalda wrote:
> > > On Thu, 7 May 2026 at 01:11, Laurent Pinchart wrote:
> > > > On Wed, May 06, 2026 at 03:59:20PM -0700, Patchwork Integration wrote:
> > > > > Dear Laurent Pinchart:
> > > > >
> > > > > Thanks for your patches! Unfortunately the Media CI robot detected some
> > > > > issues:
> > > > >
> > > > > # Test media-patchstyle:./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch media style
> > > > > ERROR: ./0001-Revert-media-renesas-vsp1-Initialize-format-on-all-p.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by
> > > > > ERROR: Commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6 found in the stable tree, but stable@vger.kernel.org not in Cc:
> > > > >
> > > > > # Test media-patchstyle:./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch media style
> > > > > ERROR: ./0002-Revert-media-renesas-vsp1-brx-Fix-format-propagation.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by
> > > >
> > > > I'm not going to add your SoB to my patches :-)
> > >
> > > You did not get the memo. From now on, all patches in the kernel need
> > > to be SoB my me :P
> > >
> > > Sorry about that, Yesterday I had to recreate the local repo and
> > > forgot to set the proper committer. It should be fixed now.
> > >
> > > > > ERROR: Commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f found in the stable tree, but stable@vger.kernel.org not in Cc:
> > > >
> > > > I don't see these commits in any of the stable branches. Does the
> > > > message mean the mainline tree, not the stable tree ?
> > >
> > > It means the stable tree
> > >
> > > ribalda@ribalda:~/work/linux$ git fetch
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
> > > 937f3e6b51f1cea079be9ba642665f2bf8bcc31f
> > > From git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux
> > >  * branch
> > > 937f3e6b51f1cea079be9ba642665f2bf8bcc31f -> FETCH_HEAD
> >
> > Ah right. But I don't think that's relevant. The commit is from the
> > master branch of the stable tree, which simply mirrors Linus' tree. It's
> > not in any stable branch.
> >
> > $ git clone https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git stable
> > Cloning into 'stable'...
> > [...]
> > laurent@killaraus ~/src/kernel $ cd stable
> > laurent@killaraus ~/src/kernel/stable $ git branch -a --contains 937f3e6b51f1cea079be9ba642665f2bf8bcc31f
> > * master
> >   remotes/origin/HEAD -> origin/master
> >   remotes/origin/master
> > laurent@killaraus ~/src/kernel/stable $ git tag --contains 937f3e6b51f1cea079be9ba642665f2bf8bcc31f
> > v7.1-rc1
> > v7.1-rc2
> >
> > This means the commit hasn't been backported to stable, it has just been
> > merged to mainline.
> >
> > If the purpose of this is to check if the commit has been merged in
> > mainline, I think the message should refer to mainline. If it's to check
> > if it has been backported to a stable kernel, then those are false
> > positives.
> >
> > Note that commit ID change when they're backported. If you want to check
> > if a commit has been backported, you'll need to grep for
> >
> >     commit ${upstream_commit_id} upstream.
> >
> > in commit *messages* of all stable branches.
> >
> > > > Given that this series should be merged in v7.1 as a regression fix, why
> > > > should it CC stable ?
> > >
> > > Somehow that patch has been backported, so I guess it should cc stable.
> >
> > No, it hasn't been backported.
> 
> You are completely right. And we have been doing this wrong for a long time....
> 
> We have a challenge that it is not trivial to fix. The builder do not
> have a clone of linus-stable, it queries it with something similar to
> "git ls-remote". So I cannot use "git log | grep".
> 
> Ideally we could have a web server to check if a sha has been
> backported, but that does not exist yet. It could probably be a nice
> little vibecoding project.

You had me interested until I read vibecoding. /me walks out the door.

> The question right now is if it is best to disable the check
> completely or keep it and live with the false positives.
> 
> Need to check with my pillow.

Given that the check essentially flags any patch that Fixes: a commit
present in mainline, I don't think we should keep it in its current
form. If desired, we could replace it with a check that flags Fixes:
without CC: stable, unconditionally. I think that's too strict though,
so it would need to be a warning that wouldn't block merging.

> > > > > Please fix your series, and upload a new version. If you have a patchwork
> > > > > account, do not forget to mark the current series as Superseded.
> > > > >
> > > > > For more details, check the full report at:
> > > > > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/99198847/artifacts/report.htm .
> > > > >
> > > > >
> > > > >
> > > > > Best regards, and Happy Hacking!
> > > > > Media CI robot on behalf of the linux-media community.
> > > > >
> > > > > ---
> > > > > Check the latest rules for contributing your patches at:
> > > > > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> > > > >
> > > > > If you believe that the CI is wrong, kindly open an issue at
> > > > > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> > > > > to this message.

-- 
Regards,

Laurent Pinchart